Ah, of course. It does highlight why having so many copies of essentially the same code is a bad idea, but it is a difficult pattern to get rid of in Tianocore. Thanks, Ard.

ArmVirtQemuKernel uses ArmVirtPkg/PrePi/Arm/ModuleEntryPoint.S which is not affected by this bug. as it turns out, only BeagleBoardPkg uses the generic PrePi code. wrote:

Apologies for the breakage. As it turns out, ArmVirtQemuKernel does work even with this bug, probably due to the fact that its PcdCoreCount == 1 (or simply that it uses the UniCore flavor rather than

BaseMemoryLib has recently been extended with an API function IsZeroBuffer(), so copy the default implementation into BaseMemoryLibStm as well. Contributed-under: TianoCore Contribution Agreement

BaseMemoryLib has recently been extended with an API function IsZeroGuid(), so copy the default implementation into BaseMemoryLibStm as well. Contributed-under: TianoCore Contribution Agreement

The BaseMemoryLibVstm implementation of BaseMemoryLib is ARM only, uses the NEON register file despite the fact that the UEFI spec does not allow it, and is currently not used anywhere. So remove

The BaseMemoryLib API has recently been extended with IsZeroGuid() and IsZeroBuffer(), so copy the generic implementations into the ArmPkg version of this library. Ard Biesheuvel (3): ArmPkg:

The prototypes of EbcInterpret() and ExecuteEbcImageEntryPoint() are private to the AARCH64 implementation of EbcDxe, so we can shuffle the arguments around a bit and make the assembler thunking glue

Instead of pessimistically copying at least 64 bytes from the VM stack to the native stack, and popping off the register arguments again before doing the native call, try to avoid touching the stack

The thunk generation is needlessly complex, given that it attempts to deal with variable length instructions, which don't exist on AArch64. So replace it with a simple template coded in assembler,

Change to consistent // style comments. Also, remove bogus global definitions for external functions, and move the real exports to the top of the file. Contributed-under: TianoCore Contribution

This is v5 of my proposed changes to the AARCH64 implementation of EbcDxe contributed by Jeff Brasen, which has recently been merged into Tianocore. Changes since v5: - added Leif's ack (#3) - cc

Rename local function name BootMenuApp to BootManagerMenuApp to align to other public function name. Cc: Ruiyu Ni <ruiyu.ni@...> Contributed-under: TianoCore Contribution Agreement

BootManagerMenuApp boot option is handled by EfiBootManagerGetBootManagerMenu. Don't need to handle it again when parse LoadFile protocol. Cc: Ruiyu Ni <ruiyu.ni@...> Cc: Eric Dong

Reviewed-by: Ruiyu Ni <ruiyu.ni@...>

In shell spec, the usage of "Drvcfg" command is: drvcfg [-l XXX] [-c] [-f <Type>|-v|-s] [DriverHandle [DeviceHandle [ChildHandle]]] [-i filename] [-o filename]. The parameter number(doesn't include

When user uses the command "bcfg driver|boot [dump [-v]]", the number of command line value parameters (doesn't include the flag) must be three. We can add this point to check whether using this

reviewed should mean tested ;) took me some time to find out why my system currently doesn't boot anymore but here's the fix for this commit: diff --git

it doesn't. it just seems that if the crc text field is not empty it calculates the crc of the crc, so you have to hit the "Reset CRC" button before reprocessing the text. wrote:

Reviewed-by: Jiewen.yao@...