Yeah, well, you made a good point. That sounds straightforward enough. Still, I am going to let someone with better python foo pick up that part Thanks, Ard.

Reviewed-by: Thomas Huth <thuth@...>

Reviewed-by: Thomas Huth <thuth@...>

Reviewed-by: Liming Gao <liming.gao@...>

Reviewed-by: Liming Gao <liming.gao@...>

Thomas: Thanks for your catching. Some similar issues also exist in header files in MdePkg. Could you help fix them also? Thanks Liming

According to PCI spec the next AER capability is relative to the beginning of PCI configuration space. Hence substract the base offset to get the next capability. "-_e" option is changed from

Ard, I was just trying to start a conversation, but I can't complain about a patch. Given I seem to be having a good day with "The Force"(tm)... To process the clipboard Python tkinter makes it

Thanks Thomas and Laszlo. Series Reviewed-by: Jordan Justen <jordan.l.justen@...>

From: Thomas Huth <thuth@...> Correct some typos (discovered with the codespell utility) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Huth

Run "unix2dos" on the affected files. "git show -b" produces no diff for this patch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@...> Cc: Jordan

The header file includes the UTF-8 encoding (0xE2 0x80 0x99) of the U+2019 (RIGHT SINGLE QUOTATION MARK) code point. Replace it with a simple apostrophe (U+0027, ASCII 0x27). Contributed-under:

Patch #3 was submitted by Thomas originally, and it was good, but it showed me that "OvmfPkg/Library/NvVarsFileLib/FsAccess.c" had LF line terminators actually. So I ran the following command, and

Hi Thomas, thank you for the contribution. The patch is good (I verified it with "git show --word-diff" as well; that helps a lot). Reviewed-by: Laszlo Ersek <lersek@...> However, applying

Correct the typos in some files of MdePkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Huth <thuth@...> --- .../BaseExtractGuidedSectionLib.c

Correct some typos (discovered with the codespell utility) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Huth <thuth@...> ---

I think it's not possible because they enable ARM_UNWIND when compiling a THUMB2_KERNEL. porting libunwind would be hard because of UEFI's architecture. every *.efi would need a section with unwind

Implement the backtrace formattting suggested by Andrew, i.e., IRQ Exception at 0x000000005BE182B0 PC 0x00005BE182B0 (0x00005BE14000+0x000042B0) [ 0] ArmCpuDxe.dll PC 0x00005BE15770

Ard, In these kind of dumps I find it useful to also display the offset into the PE/COFF image. ArmVeNorFlashDxe.dll (0x00000000F5EA4AE8) loaded at 0x00000000F5E90000 offset 0x00014AE9 The reason

Right, so I was contemplating a minor rewrite of the gic driver to make this sort of thing less likely in the future ... but quickly realised it wouldn't be a minor one. So: Reviewed-by: Leif