The header file includes the UTF-8 encoding (0xE2 0x80 0x99) of the U+2019 (RIGHT SINGLE QUOTATION MARK) code point. Replace it with a simple apostrophe (U+0027, ASCII 0x27). Contributed-under:

Patch #3 was submitted by Thomas originally, and it was good, but it showed me that "OvmfPkg/Library/NvVarsFileLib/FsAccess.c" had LF line terminators actually. So I ran the following command, and

Hi Thomas, thank you for the contribution. The patch is good (I verified it with "git show --word-diff" as well; that helps a lot). Reviewed-by: Laszlo Ersek <lersek@...> However, applying

Correct the typos in some files of MdePkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Huth <thuth@...> --- .../BaseExtractGuidedSectionLib.c

Correct some typos (discovered with the codespell utility) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Huth <thuth@...> ---

I think it's not possible because they enable ARM_UNWIND when compiling a THUMB2_KERNEL. porting libunwind would be hard because of UEFI's architecture. every *.efi would need a section with unwind

Implement the backtrace formattting suggested by Andrew, i.e., IRQ Exception at 0x000000005BE182B0 PC 0x00005BE182B0 (0x00005BE14000+0x000042B0) [ 0] ArmCpuDxe.dll PC 0x00005BE15770

Ard, In these kind of dumps I find it useful to also display the offset into the PE/COFF image. ArmVeNorFlashDxe.dll (0x00000000F5EA4AE8) loaded at 0x00000000F5E90000 offset 0x00014AE9 The reason

Right, so I was contemplating a minor rewrite of the gic driver to make this sort of thing less likely in the future ... but quickly realised it wouldn't be a minor one. So: Reviewed-by: Leif

The new accelerated ARM and AARCH64 implementations take advantage of features that are only available when the MMU and Dcache are on. So restrict the use of this library to the DXE phase or

This adds AARCH64 support to BaseMemoryLibOptDxe, based on the cortex-strings library. All string routines are accelerated except ScanMem16, ScanMem32, ScanMem64 and IsZeroBuffer, which can wait for

This adds ARM support to BaseMemoryLibOptDxe, partially based on the cortex-strings library (ScanMem) and the existing CopyMem() implementation from BaseMemoryLibStm in ArmPkg. All string routines

Since the default BaseMemoryLib should be callable from any context, including ones where unaligned accesses are not allowed, it implements InternalCopyMem() and InternalSetMem() using byte accesses

This adds ARM and AARCH64 support to both BaseMemoryLib (generic C) and BaseMemoryLibOptDxe (accelerated). The former can be used anywhere, the latter only in places where the caches are guaranteed to

OK, I spoke a bit too soon. The 'pop' does not actually increment the stack pointer, so while the push does make sense (and pushing the pc in addition is just informational), the pop should actually

Pushed, with the below folded in to prevent the RELEASE build from breaking on an 'unused function' Thanks, Ard. ---

Pushed, thanks.

That's a lot less complex, thanks. Reviewed-by: Leif Lindholm <leif.lindholm@...>

The UEFI spec stipulates that unaligned accesses should be enabled on CPUs that support them, which means all of them, given that we no longer support pre-v7 ARM cores, and the AARCH64 bindings

Which was exactly what I was asking :) So no need to change (but drop the '\'). / Leif