Cc: Wu Jiaxin <jiaxin.wu@...> Cc: Zhang Lubo <lubo.zhang@...> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan.fu@...> ---

Reviewed-by: Erik Bjorge <erik.c.bjorge@...>

Reviewed-by: Erik Bjorge <erik.c.bjorge@...>

Reviewed-by: Erik Bjorge <erik.c.bjorge@...>

Reviewed-by: Erik Bjorge <erik.c.bjorge@...>

When python tool exe doesn't exist, toolsetup.bat will set up PYTHONPATH, and set python tool dos script directory into system PATH. Cc: Yonghong Zhu <yonghong.zhu@...> Cc: Michael Kinney

If PYTHON_FREEZER_PATH is not set, Python tools will not be freeze. Cc: Yonghong Zhu <yonghong.zhu@...> Cc: Michael Kinney <michael.d.kinney@...> Cc: Erik Bjorge

Python tool may run from source as the dos batch files. So, update python code to call external tools with shell true mode. Cc: Yonghong Zhu <yonghong.zhu@...> Cc: Michael Kinney

Add 13 windows batch files for every python tool. Cc: Yonghong Zhu <yonghong.zhu@...> Cc: Michael Kinney <michael.d.kinney@...> Cc: Erik Bjorge

When Python tool exe files don't exist, toolsetup.bat will configure PYTHONPATH to python source code, and set BaseTools\BinWrappers\WindowsLike into system PATH directory. Then, windows batch files

* One idea is to parse the PCI expansion ROM in order to see what image types are contained within. If there is no (Code type == 0x00) image in the oprom, then the oprom is useless for legacy boot

That works around the problem, but does not solve it. MdeModulePkg is supposed to be generic/universal, and still, it contains a Intel/CSM specific hack to degrade 64-bit BARs of any device that has

You could use IncompatiblePciDevice protocol. If you have no clue I will give you more information my tomorrow. Thanks, Ray 在 2016年9月12日，下午9:16，Ard Biesheuvel

Yes, please. And please keep us informed about any solutions you come up with. Thanks, Ard.

HI Ard We should not let MdeModulePkg depend on IntelFrameworkPkg. You patch violates the dependency rule. I suggest we figure out other solution to resolve the problem. Thank you Yao Jiewen

True, but I have sent out a patch nonetheless. Let's at least have the discussion.

The practice of unconditionally degrading 64-bit PCI MMIO BARs to 32-bit if the device in question happens to have an option ROM is based on platform constraints, not architectural constraints, and

s/library/protocol/ Yes, it should be. ... IMO, the specific degradation logic in the PCI Bus driver is simplistic; for example, if it finds a PCI oprom for the device, it could parse it to see if

Formatting / reviewing the first patch with "--find-copies-harder" works wonders, so I recommend that flag for similar future posts. Series Reviewed-by: Laszlo Ersek

Thank you guys, pushed as commit range 5654835bd138..8c0b0b34f787. Cheers Laszlo