Hi Khasim, I had some questions about this path: Are the modifications in this file required ? The indentation seems correct to me There are the '@return' and '@retval' keywords to indicate what

From: Corvin Köhne <CorvinK@...> QemuFwCfg is more powerful and has more use cases than BhyveFwCtl. Try to use QemuFwCfg in first place. If that fails, fall back

It's much easier to create configuration dependend ACPI tables for bhyve than for OVMF. For this reason, don't use the statically created ACPI tables provided by OVMF. Instead use the

Reviewed-by: Ray Ni <ray.ni@...>

The SecurityStubDxe driver may be provided by platform payload. In UefiPayloadPkg\UefiPayloadPkg.fdf file, SecurityStubDxe should only be included if SECURITY_STUB_ENABLE is TRUE Cc: Ray Ni

It's fine this time, but please add [staging/RedfishClientPkg] when next time send the patch against edk2-staging. Only one comment in below, others look good to me. Reviewed-by: Abner Chang

I noticed a difference between V2 and V3: V2: - AcpiBoardInfo = BuildHobFromAcpi (SysTableInfo.AcpiTableBase); + AcpiBoardInfo = BuildHobFromAcpi (AcpiTableHob->Rsdp.AcpiTableBase); V3: -

SystemTableInfo GUID is not a Spec defined GUID. But the latest SBL uses SystemTableInfo to get ACPI and SMBIOS table information. So moving the SystemTableInfo GUID implementation to

Initial common header file and meta files for feature drivers. Signed-off-by: Nickle Wang <nickle.wang@...> Cc: Abner Chang <abner.chang@...> Cc: Liming Gao <gaoliming@...> ---

This commit adds below protocol and common header files for Redfish feature drivers. - edk2 Redfish resource config protocol: this protocol is used by feature drivers for internal communication -

Reviewed-by: Jian J Wang <jian.j.wang@...> Regards, Jian

Hi Jian, Thanks for the comment. Patch v3 is just sent with the update. Please help to review. Thank you, Ma Hua

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3680 This patch fixes the following issue: The global variable gHandleList is a linked list. This list is locked when a entry is added or removed

It seems make sense. Would you please: 1) Fila a Bugzilla - https://bugzilla.tianocore.org/ 2) Describe what unit test you have done. Especially, if multiple cert list/data have been tested. I ask

Min, The change is to provide a totally different MP service in TDX case. It makes the MpInitLib more complicated. How about? 1. Change CpuMpPei/CpuMpDxe to return directly in TDX case. 2. Add new

From: Kazuhiko Sakamoto <sakamoto.kazuhiko@...> Test the @ControllerHandle is not NULL and is actually managed by this driver. Contributed-under: TianoCore Contribution Agreement

From: Kazuhiko Sakamoto <sakamoto.kazuhiko@...> Test the @ControllerHandle is not NULL and is actually managed by this driver. Contributed-under: TianoCore Contribution Agreement

From: Kazuhiko Sakamoto <sakamoto.kazuhiko@...> Test the @ControllerHandle is not NULL and is actually managed by this driver. Contributed-under: TianoCore Contribution Agreement

From: Kazuhiko Sakamoto <sakamoto.kazuhiko@...> Test the @ControllerHandle is not NULL and is actually managed by this driver. Contributed-under: TianoCore Contribution Agreement

Hello, Here are the patches to fix the SynQuacer related drivers to test whether the ControllerHandle is managed by that driver correctly. These bugs are found by edk2-test. Thank