From: Bret Barkelew <brbarkel@...> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3651 Cc: Liming Gao <gaoliming@...> Cc: Dandan Bi <dandan.bi@...> Cc: Liming Gao

From: Bret Barkelew <brbarkel@...> There are a number of Arm-specific accesses that are abstracted behind this. It may need to be refactored to work better across architectures. REF:

From: Bret Barkelew <brbarkel@...> Cc: Ard Biesheuvel <ardb+tianocore@...> Cc: Liming Gao <gaoliming@...> Cc: Zhiguang Liu <zhiguang.liu@...> Cc: Sean Brogan

From: Bret Barkelew <brbarkel@...> This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu

From: Bret Barkelew <brbarkel@...> TODO: Might keep the name of the .inf. Pending discussion. This aligns better with Mu's philosophy around dependency structuring and is one of the steps

From: Bret Barkelew <brbarkel@...> This extra interface is redundant and unnecessary. Dropping it is more EDK2-ish. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3647 Cc: Leif

From: Bret Barkelew <brbarkel@...> StandaloneMmMmuLib has been turned into an implementation of the ArmMmuLib class (without any change to the interface itself), so this module can now

From: Bret Barkelew <brbarkel@...> Drop switch from the custom "StandaloneMmMmuLib" class to the more generic "ArmMmuLib" class and add the missing functions to fulfill that

From: Bret Barkelew <brbarkel@...> Not sure what all module types this HAS been validated against, but it doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. REF:

This series of patch commits moves a number of modules and libraries around in order to better un-silo the Arm-specific code. Unnecessary abstractions were removed, some duplicate code was abstracted,

Hi Vineel, I will integrate the change to edk2 tomorrow. For now: Reviewed-by: Maciej Rabeda <maciej.rabeda@...> Thanks, Maciej

If the implementation didn't make so many calls into Arm-specific libs for SMC servicing, it could stay right where it is. It's just that untangling that Gordian knot is outside my ken.

Will address.

Will address. Thanks!

Good call. Maintainers, your opinion? - Bret

I’d be amenable to that. @Sean? - Bret

Hi Folks, Thanks for reviewing the patch. May I know what are the next steps to get it in to edk2? I have already updated the same in

Thanks for incorporating the feedback. Few more minor comments based on the new patch: 1. The description of "DieIndex" perhaps should be modified to " Index of the die in the package" to make it

Copy the TPM 1.2 physical presence interface support from SecurityPkg DxeTcgPhysicalPresenceLib.c along with its .inf and .uni files into OvmfPkg. Fix EFI_F_INFO and EFI_D_ERROR to meet code

This series adds support for the full TPM 1.2 Physical Presence Interface (PPI) and activates the TPM 1.2 menu at the end. PPI is a prerequisite for the menu to work. The modifications to the