Hi Pierre, Reviewed-by: Joey Gouly <joey.gouly@...> Thanks, Joey

Nate : Seems you forgot to see [edk2-platforms] [PATCH V2] WhitleyOpenBoardPkg : Support for Junction City Platform changes. Patch V2 has all the required changes and it was reviewed by Isaac. Thank

Reviewed-by: Rebecca Cran <rebecca@...> Thanks, I'm now seeing: ERROR: On Arm based systems, all cache properties must be provided in the cache type structure. Missing 'Write Policy Valid'

How is this change related to the items listed in the commit log? If there are code issues affecting this library, please fix them in a separate patch.

Why is it justified to implement a broken version of this routine? This is not a NULL library class that only exists for build test purposes, it is actually used in production builds. If the TDVF

Hi Zhichao Gao, Ray Ni, Sami Mujawar, Please review and create PR if looks good. Thanks AbduL

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 With the introduction of TDVF Config-B, some Tdx libs should be added in below dsc to prevent the broken of building. -

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 The entrypoint of DxeAcpiTimerLib checks HostBridgeDevId by reading PcdOvmfHostBridgePciDevId. If the DevId is not set, ASSERT is triggered.

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdvf Config-B skip PEI phase to reduce attack surface. So instead of jumping to SecStartupPhase2 (), TdxStartup () is called. This

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 These PCDs are set in PEI phase in Config-A. But in Config-B PEI phase is skipped. So they're set here. Cc: Brijesh Singh

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 TdxStarupLib provides a function (TdxStartup ()) which brings up the Tdx guest from SEC phase to DXE phase. PEI phase is skipped because

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 SecPlatformLibQemuTdx initialize the platform in Tdx guest. It sets the HostBridgePciDevId in PlatformInfoHob which will be transferred to DXE

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 This library is needed by EmbeddedPkg/PrePiHobLib to set / get the Hob list pointer. Cc: Brijesh Singh <brijesh.singh@...> Cc: James

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 There are below new functions added in EmbeddedPkg/PrePiLib. 1. FfsAnyFvFindFileByName This function is to find the file by name in the

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 This function is a null stub to make the build success. Cc: Brijesh Singh <brijesh.singh@...> Cc: James Bottomley

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total

I see that DBG2/SPCR spec (https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table) defines 0x10 for Serial type for BCM2835: 0x0010 BCM2835 Should the spec be

Hi Rebecca, Thank you for reporting this. After further investigation I believe the issue is in the PPTT parser when it tries to report an error with the cache flags it performs an incorrect

Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3770) The PPTT parser in AcpiView incorrectly dereferences a pointer to FlagName when trying to log an error with the PPTT cache flags,