|
Re: [PATCH v1 0/3] EmbeddedPkg: Enable CI
Ard,
Why would you want to do that? The whole point of CI is to establish a minimum quality level for all code in the project.
They can be disabled with updates to the YAML file. Checks can be
Ard,
Why would you want to do that? The whole point of CI is to establish a minimum quality level for all code in the project.
They can be disabled with updates to the YAML file. Checks can be
|
By
Michael D Kinney
·
#93870
·
|
|
Re: [PATCH v1 0/3] EmbeddedPkg: Enable CI
<mikuback@...> wrote:
The only thing I'd like to know is how I can override the CI and merge
a PR that was rejected by the checks you are enabling here.
<mikuback@...> wrote:
The only thing I'd like to know is how I can override the CI and merge
a PR that was rejected by the checks you are enabling here.
|
By
Ard Biesheuvel
·
#93869
·
|
|
Re: [PATCH v1 0/3] EmbeddedPkg: Enable CI
Hi Ard,
I haven't seen any action items for the v1 series.
Can you please check the series again and let me know if you have any further concerns?
Thanks,
Michael
Hi Ard,
I haven't seen any action items for the v1 series.
Can you please check the series again and let me know if you have any further concerns?
Thanks,
Michael
|
By
Michael Kubacki
·
#93868
·
|
|
Re: [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file
Hi Chasel,
Your CI YAML file feedback in v1 is addressed now in v2.
Can you please provide your review on this patch and [PATCH v2 5/6]?
Note that I updated the commit message for this patch to
Hi Chasel,
Your CI YAML file feedback in v1 is addressed now in v2.
Can you please provide your review on this patch and [PATCH v2 5/6]?
Note that I updated the commit message for this patch to
|
By
Michael Kubacki
·
#93867
·
|
|
Re: [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file
Hi Jian,
Can you please provide a review for this patch?
Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series will be ready once this patch is reviewed.
Thanks,
Michael
Hi Jian,
Can you please provide a review for this patch?
Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series will be ready once this patch is reviewed.
Thanks,
Michael
|
By
Michael Kubacki
·
#93866
·
|
|
[PATCH v2 6/6] .azurepipelines: Add IntelFsp2Pkg and IntelFsp2WrapperPkg to CI
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
Adds these packages to a new edk2 matrix job so they can be validated
in edk2 CI.
Cc:
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
Adds these packages to a new edk2 matrix job so they can be validated
in edk2 CI.
Cc:
|
By
Michael Kubacki
·
#93865
·
|
|
[PATCH v2 5/6] IntelFsp2WrapperPkg: Add CI YAML file
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
Adds IntelFsp2WrapperPkg to the list of supported build packages
for edk2 CI and
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
Adds IntelFsp2WrapperPkg to the list of supported build packages
for edk2 CI and
|
By
Michael Kubacki
·
#93864
·
|
|
[PATCH v2 4/6] IntelFsp2WrapperPkg: Fix code formatting errors
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
This package did not have CI enabled so code changes were merged
that fail uncrustify
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
This package did not have CI enabled so code changes were merged
that fail uncrustify
|
By
Michael Kubacki
·
#93863
·
|
|
[PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
Adds IntelFsp2Pkg to the list of supported build packages for edk2
CI and defines an
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
Adds IntelFsp2Pkg to the list of supported build packages for edk2
CI and defines an
|
By
Michael Kubacki
·
#93862
·
|
|
[PATCH v2 2/6] IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate GUID
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
The FILE_GUID for this library instance file is a duplicate
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
The FILE_GUID for this library instance file is a duplicate
|
By
Michael Kubacki
·
#93861
·
|
|
[PATCH v2 1/6] IntelFsp2Pkg: Fix code formatting errors
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
This package did not have CI enabled so code changes were merged
that fail uncrustify
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
This package did not have CI enabled so code changes were merged
that fail uncrustify
|
By
Michael Kubacki
·
#93860
·
|
|
[PATCH v2 0/6] Enable CI in Intel FSP Packages
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
- Enables CI in IntelFsp2Pkg and IntelFsp2WrapperPkg.
- Fixes several pre-existing
From: Michael Kubacki <michael.kubacki@...>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4048
- Enables CI in IntelFsp2Pkg and IntelFsp2WrapperPkg.
- Fixes several pre-existing
|
By
Michael Kubacki
·
#93859
·
|
|
Re: [PATCH v3 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib
Thanks Leif. I will fix as your suggestion.
-Nhi
Thanks Leif. I will fix as your suggestion.
-Nhi
|
By
Nhi Pham
·
#93858
·
|
|
Re: [edk2-platforms][PATCH V1 1/1] Maintainers.txt: Add QemuOpenBoardPkg maintainers
Pushed as 8d8bb28d2c..17a682058c
Pushed as 8d8bb28d2c..17a682058c
|
By
Isaac Oram
·
#93857
·
|
|
Re: [edk2-platforms][PATCH V1 1/1] Maintainers.txt: Add QemuOpenBoardPkg maintainers
Thanks for this.
Reviewed-by: Leif Lindholm <quic_llindhol@...>
Thanks for this.
Reviewed-by: Leif Lindholm <quic_llindhol@...>
|
By
Leif Lindholm
·
#93856
·
|
|
Re: [PATCH] IntelFsp2Pkg: Fix FspSecCoreI build failure.
Patch merged:
https://github.com/tianocore/edk2/commit/f46c7d1e36c901e72cc0daee8429275bcb319eb9
Thanks,
Chasel
Patch merged:
https://github.com/tianocore/edk2/commit/f46c7d1e36c901e72cc0daee8429275bcb319eb9
Thanks,
Chasel
|
By
Chiu, Chasel
·
#93855
·
|
|
Re: [PATCH] Maintainers.txt: Update email address
Reviewed-by: Andrew Fish <afish@...>
Reviewed-by: Andrew Fish <afish@...>
|
By
Andrew Fish
·
#93854
·
|
|
Re: [edk2-platforms][PATCH 0/2] Platform/Sgi: Update serial port usage
Apologies for the delay.
Merged as f4679715a40d..8d8bb28d2c4b
Regards,
Sami Mujawar
Apologies for the delay.
Merged as f4679715a40d..8d8bb28d2c4b
Regards,
Sami Mujawar
|
By
Sami Mujawar
·
#93853
·
|
|
Re: [PATCH] Maintainers.txt: Update email address
Reviewed-by: Michael D Kinney <michael.d.kinney@...>
Reviewed-by: Michael D Kinney <michael.d.kinney@...>
|
By
Michael D Kinney
·
#93852
·
|
|
Re: [PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm
Patch merged:
https://github.com/tianocore/edk2/commit/981bf66d5a7b1a31be5ffccc15fe13b97300e124
Thanks,
Chasel
Patch merged:
https://github.com/tianocore/edk2/commit/981bf66d5a7b1a31be5ffccc15fe13b97300e124
Thanks,
Chasel
|
By
Chiu, Chasel
·
#93851
·
|