|
Re: [PATCH 08/10] OvmfPkg: Update Sec to support Tdvf Config-B
Oh, wow. So you compile in PEI, then decide at runtime whenever you
use it or not?
No. Please don't. That's just silly. If you don't want use PEI, ok,
fine, but please go the way then, remove PEI
|
Oh, wow. So you compile in PEI, then decide at runtime whenever you
use it or not?
No. Please don't. That's just silly. If you don't want use PEI, ok,
fine, but please go the way then, remove PEI
|
By
Gerd Hoffmann
·
#84892
·
|
|
Re: [PATCH v2 0/2] Update brotli to the latest commit
Liming,
Yes, yes it does. No need to turn off Werror now.
Thanks,
Pedro
|
Liming,
Yes, yes it does. No need to turn off Werror now.
Thanks,
Pedro
|
By
Pedro Falcato
·
#84891
·
|
|
Re: [PATCH 06/10] OvmfPkg: Add TdxStartupLib
Hi,
Can this ever be false in a x64 build?
[ ... ]
This branch never runs, FvInstance is explicity set to 1 by the caller.
There is OvmfPkg/Include/IndustryStandard/PageTable.h
Yet another copy of
|
Hi,
Can this ever be false in a x64 build?
[ ... ]
This branch never runs, FvInstance is explicity set to 1 by the caller.
There is OvmfPkg/Include/IndustryStandard/PageTable.h
Yet another copy of
|
By
Gerd Hoffmann
·
#84890
·
|
|
Re: [PATCH 05/10] OvmfPkg: Add SecPlatformLibQemuTdx
Hi,
Why this is needed?
They are in OvmfPkg/Include/OvmfPlatforms.h, no need to copy them over.
Cut+Paste from PlatformPei
Please refactor the code (move the functions needed to a Library?) so
|
Hi,
Why this is needed?
They are in OvmfPkg/Include/OvmfPlatforms.h, no need to copy them over.
Cut+Paste from PlatformPei
Please refactor the code (move the functions needed to a Library?) so
|
By
Gerd Hoffmann
·
#84889
·
|
|
Re: [PATCH 01/10] OvmfPkg: Introduce IntelTdxX64 for TDVF Config-B
Hi,
Hmm, that doesn't look very stripped down to me ...
take care,
Gerd
|
Hi,
Hmm, that doesn't look very stripped down to me ...
take care,
Gerd
|
By
Gerd Hoffmann
·
#84888
·
|
|
Re: [PATCH V4 31/31] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg
This is more than a pure move.
Functional changes should be a separate patch.
What's this? uncrustify?
Reformating should be a separate patch too.
take care,
Gerd
|
This is more than a pure move.
Functional changes should be a separate patch.
What's this? uncrustify?
Reformating should be a separate patch too.
take care,
Gerd
|
By
Gerd Hoffmann
·
#84887
·
|
|
Re: [PATCH V4 30/31] OvmfPkg: Switch timer in build time for OvmfPkg
Acked-by: Gerd Hoffmann <kraxel@...>
|
Acked-by: Gerd Hoffmann <kraxel@...>
|
By
Gerd Hoffmann
·
#84886
·
|
|
Re: [PATCH V4 29/31] UefiCpuPkg: Setting initial-count register as the last step
Acked-by: Gerd Hoffmann <kraxel@...>
|
Acked-by: Gerd Hoffmann <kraxel@...>
|
By
Gerd Hoffmann
·
#84885
·
|
|
Re: [PATCH V4 28/31] OvmfPkg: Rename XenTimerDxe to LocalApicTimerDxe
Acked-by: Gerd Hoffmann <kraxel@...>
|
Acked-by: Gerd Hoffmann <kraxel@...>
|
By
Gerd Hoffmann
·
#84884
·
|
|
Re: [PATCH V4 27/31] OvmfPkg: Update IoMmuDxe to support TDX
Acked-by: Gerd Hoffmann <kraxel@...>
|
Acked-by: Gerd Hoffmann <kraxel@...>
|
By
Gerd Hoffmann
·
#84883
·
|
|
Re: [PATCH V4 26/31] OvmfPkg/QemuFwCfgLib: Support Tdx in QemuFwCfgDxe
Acked-by: Gerd Hoffmann <kraxel@...>
take care,
Gerd
|
Acked-by: Gerd Hoffmann <kraxel@...>
take care,
Gerd
|
By
Gerd Hoffmann
·
#84882
·
|
|
Re: [PATCH V4 25/31] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library
Can we move most of the code to a (x64) page table library instead of
cut+pasting like this, please?
Brijesh: BaseMemEncryptSevLib is in the same boat.
take care,
Gerd
|
Can we move most of the code to a (x64) page table library instead of
cut+pasting like this, please?
Brijesh: BaseMemEncryptSevLib is in the same boat.
take care,
Gerd
|
By
Gerd Hoffmann
·
#84881
·
|
|
Re: [PATCH V4 24/31] OvmfPkg: Add TdxDxe driver
Acked-by: Gerd Hoffmann <kraxel@...>
take care,
Gerd
|
Acked-by: Gerd Hoffmann <kraxel@...>
take care,
Gerd
|
By
Gerd Hoffmann
·
#84880
·
|
|
Re: [PATCH V4 23/31] OvmfPkg: Update AcpiPlatformDxe to alter MADT table
Acked-by: Gerd Hoffmann <kraxel@...>
take care,
Gerd
|
Acked-by: Gerd Hoffmann <kraxel@...>
take care,
Gerd
|
By
Gerd Hoffmann
·
#84879
·
|
|
Re: [PATCH V4 22/31] OvmfPkg: Update PlatformPei to support TDX
fwcfg patch adds a similar function. Can't we have a single function
somewhere, or have a #define for this check, instead of doing this
cut+paste programming?
Likewise, I've seen this before in
|
fwcfg patch adds a similar function. Can't we have a single function
somewhere, or have a #define for this check, instead of doing this
cut+paste programming?
Likewise, I've seen this before in
|
By
Gerd Hoffmann
·
#84878
·
|
|
Re: [PATCH v1 2/2] ArmPkg: MmCommunicationDxe: Update MM communicate input arguments checks
A bullet list like this is usually a strong hint that the patch should
be split up, and this case is no different. Please split this up into
3 separate patches so that us poor reviewers have an easier
|
A bullet list like this is usually a strong hint that the patch should
be split up, and this case is no different. Please split this up into
3 separate patches so that us poor reviewers have an easier
|
By
Ard Biesheuvel
·
#84877
·
|
|
Re: [PATCH edk2 v1 1/3] StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field
(+ Masahisa, Masami)
Could someone please check how this change of interpretation affects
standalone MM running on SynQuacer?
|
(+ Masahisa, Masami)
Could someone please check how this change of interpretation affects
standalone MM running on SynQuacer?
|
By
Ard Biesheuvel
·
#84876
·
|
|
Re: [PATCH 0/3] ArmPkg/SMBIOS: Update HII string settings for SMBIOS
<nhi@...> wrote:
Anyone care to review this?
|
<nhi@...> wrote:
Anyone care to review this?
|
By
Ard Biesheuvel
·
#84875
·
|
|
Re: [PATCH V4 21/31] UefiCpuPkg: Update AddressEncMask in CpuPageTable
Hmm?
With that dropped:
Acked-by: Gerd Hoffmann <kraxel@...>
take care,
Gerd
|
Hmm?
With that dropped:
Acked-by: Gerd Hoffmann <kraxel@...>
take care,
Gerd
|
By
Gerd Hoffmann
·
#84874
·
|
|
Re: [PATCH V4 20/31] MdeModulePkg: Add PcdTdxSharedBitMask
Acked-by: Gerd Hoffmann <kraxel@...>
|
Acked-by: Gerd Hoffmann <kraxel@...>
|
By
Gerd Hoffmann
·
#84873
·
|
