Can you provide some context as to why we need to make all these x509 functions external? BaseCryptLib was intended to simplify crypto usage and not be a full featured crypto library interface. At

Reviewed-by: Isaac Oram <isaac.w.oram@...>

Format all python files in BaseTools using the following commands: $ find . -name '*.py' -exec autopep8 --in-place '{}' \; This is to make the Python code PEP8 compilant as stated in EDK II

Fix formatting of Python files in BaseTools to conform to PEP8 using autopep8. This does not fix all the warnings/errors from flake8, but I wanted to get this patch checked out first to see if

Interesting. In that case, we can continue with current approach of copy in Ovmf and add the optimization. I was assuming you want the same driver for real and virtual platforms in MdeModulePkg

On 10/10/2022 8:42 AM, Gerd Hoffmann wrote: I know this is unrelated to this patch, but should we update the release date at some point? Should we check for an allocation failure

What I would like to do is the following: - move NvVarstoreFormattedLib into MdeModulePkg (as you proposed already) - create a new NorFlashDxe in Ovmf that is cleaned up, drops the handling of locked

Great. Let me rework these patches then. Oh sorry. I forgot to modify the commit message but what I really meant was removing the code which depends upon PcdNorFlashCheckBlockLocked for virtual

AcceptMemory is not specified to avoid accepting previously accepted memory. As I understand it, AcceptMemory is purely a hardware abstraction layer for CC technologies inside the UEFI

I think that library as well as the definition of gEdkiiNvVarStoreFormattedGuid should be moved to MdeModulePkg. Then, we can look at moving NorFlashDxe in there as well. But you haven't answered my

I agree. If we can break the dependency on EmbeddedPkg due to NvVarStoreFormattedLib, then we can migrate to MdeModulePkg and all consumers can use the same driver which would be the best solution

Instead of using hard-coded string "0.0.0" for BiosVersion (which is quite useless) read PcdFirmwareVersionString and append that to the type0 entry string table. Signed-off-by: Gerd Hoffmann

From: Jason Lou <yun.lou@...> The code changes add unit tests based on current UnitTestFramework. EdkiiPeiMpServices2PpiPeiUnitTest PEI module is used to test EdkiiPeiMpServices2Ppi and

Reviewed-by: Ashraf Ali S <ashraf.ali.s@...> Regards, Ashraf Ali S Intel Technology India Pvt. Ltd. 

Enable the virtio-p9 device that is present as part of the RoS peripherals on RD-N2 platform variants. This will allow filesystem sharing between the Host PC and target platform. Signed-off-by: Vivek

Some of the Arm reference design FVP platforms support the Virtio-p9 device as part of the RoS subsystem. Add an entry for this device in the SSDT acpi table. The device entry is listed in a new SSDT

Few Arm reference design Fixed Virtual Platforms (FVPs) support Virtio-P9 device as part of the RoS subsystem. The Virtio-P9 device implements a subset of the Plan 9 file protocol over a virtio

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4082 Cc: Jian J Wang <jian.j.wang@...> Cc: Xiaoyu Lu <xiaoyu1.lu@...> Cc: Guomin Jiang <guomin.jiang@...> Signed-off-by: Qi

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4082 Cc: Jian J Wang <jian.j.wang@...> Cc: Xiaoyu Lu <xiaoyu1.lu@...> Cc: Guomin Jiang <guomin.jiang@...> Signed-off-by: Qi

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4082 Cc: Jian J Wang <jian.j.wang@...> Cc: Xiaoyu Lu <xiaoyu1.lu@...> Cc: Guomin Jiang <guomin.jiang@...> Signed-off-by: Qi