Leif: Thanks for your suggestion. I am OK to merge this patch into stable tag20211. Thanks Liming running printed as

Acked-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao

Hello, Michael Kubacki and I have prepared the patches required to apply the uncrustify changes and enable EDK II CI to check all submitted patches have been run through uncrustify. There are a

I just realized that I changed the plugin name in the patch but did not update the commit subject. Since I'm already planning to send a v4, I will update it to ".pytool/Plugin/UncrustifyCheck: Add

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3748 Adds a new CI plugin for Uncrustify. This is used to check coding standard compliance

My apology - fix typo: objection on the discussion => objective on the discussion.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2386 Enhance BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1() to handle ReadKeyStrokeEx implementation which returns EFI_NOT_READY but without

I think we are discussing under different context. First, the term "isolation" shall be clarified. In my context, "isolation" means two domain cannot impact each other. The isolation is enforced by a

Reminder: TianoCore Bug Triage - APAC / NAMO When: 11/23/2021 6:30pm to 7:30pm (UTC-08:00) America/Los

Reviewed-by: Michael Kubacki <michael.kubacki@...>

I wouldn't expect it to extend past 1 hour that often either. An occasional audit sounds good though. Do you think a BZ could be filed to track the ECC optimization work? I didn't see anything

Hi Michael, I would like to see some optimization work applied to the ECC tool to see if we can reduce the time that tool requires. If we find some easy improvements that allow larger patch series

Hi Mike, Is the plan to keep it at a 2 hour limit indefinitely (not just for these large series currently outstanding)? Thanks, Michael

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750 Large patches that modify a large number of files(e.g uncrustify) take longer to process through CI checks such as ECC. Increase the max job

Sounds good. I'll include that in v3.

Hi Michael, Thanks for the clarification. It would be good to make it clear that UncrustifyCheck is by default enabled for all packages and that the only way to disabled it is to add that section to

<michael.d.kinney@...> wrote: Where needed, Acked-by: Ard Biesheuvel <ardb@...>

Acked-by: Michael Kubacki <michael.kubacki@...>

Hi Mike, I'm fine with changing the CI plugin name to "UncrustifyCheck". It does only check files. I will make this change in a V3. That section does not need to be present. It is just giving an

Hi Mike, The simplest way to stay up-to-date is to let the stuart_update command check that the local version matches the version specified in "uncrustify_ext_dep.yaml". The version "73.0" is based