When use the UsbHcAllocMemFromBlock() and UsbHcFreeMem() to allocate memory and free memory for the UHC, it should use the corresponding host address but not the pci bus address. Signed-off-by:

Hello, I obtained the following error when trying to build a BIOS image. Traceback (most recent call last): File "/workarea/Edk2/BaseTools/Source/Python/GenFds/GenFds.py", line 371, in

Hi Liming, I agree it is both low risk and prevents an ASSERT() condition that should never be triggered. I approve for edk2-stable202111 Mike

Hello, Michael Kubacki and I have prepared the patches required to apply the uncrustify changes and enable EDK II CI to check all submitted patches have been run through uncrustify. We have

Hi Michael, I agree with these updates. Thank you for posting the branches. Mike

I suggest to merge this fix for the stable tag 202111. This fix is low risk. Thanks Liming 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Wu, Jiaxin 发送时间:

Reviewed-by: Wu Jiaxin <jiaxin.wu@...>

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3719 Token->RspData.H2AData is de-allocated on error but it is not set to NULL. HTTP module attempts to free again and cause assert.

I sent the v5 patch with the templates disabled: https://edk2.groups.io/g/devel/message/84068 I also posted that patch on this

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3748 Adds a new CI plugin for Uncrustify. This is used to check coding standard compliance

Hi Mike, How about I quickly send a v5 with the lines commented out and follow up with a patch to uncomment them that we can review but merge when ready? Thanks, Michael

The 2nd option I listed won't work. That will fail UncrustifyCheck as well because EDK II CI will insert missing file/function headers and the files will not match. We will need to comment out these

Reviewed-by: Ray Ni <ray.ni@...>

Hi Michael, Unfortunately, enabling the templates in the uncrustify.cfg files modifies 340 files with missing file/function headers that will now fail UncrustifyCheck. cmt_insert_file_header

Thanks. That makes sense. Mike

Yes. Those were redundant and detected by the Python configparser module when I used it to parse the config file. Thanks, Michael

Hi Kilian, I agree with Maciej. There should be a big emphasis on getting an *open-source* libc available in EDK2, and not relying on a proprietary, opaque binary blob. In my opinion EDK2 should pivot

Hi Michael, I see a couple settings deleted from the uncrustify.cfg. Was that in purpose? Does it change the format? -nl_func_call_start_multi_line = true # Whether to add a newline after

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3748 Adds a new CI plugin for Uncrustify. This is used to check coding standard compliance