|
Re: [edk2-platforms][PATCH V1 05/11] Platform/ARM/Morello: Add initial support for Morello SoC
Hi Chandni,
I would suggest adding a brief introduction about the Morello SoC platform in the commit message.
Otherwise, this patch looks good to me.
With the commit message updated.
Reviewed-by:
Hi Chandni,
I would suggest adding a brief introduction about the Morello SoC platform in the commit message.
Otherwise, this patch looks good to me.
With the commit message updated.
Reviewed-by:
|
By
Sami Mujawar
·
#84468
·
|
|
Re: [edk2-platforms][PATCH V1 04/11] Platform/ARM/Morello: Add ConfigurationManager for Morello SoC
Hi Chandni,
Since you have the CPU information in MADT.GICC and the PPTT table, it should be possible to use the SSDT CPU generator to create the AML description for the CPUs. This patch series can
Hi Chandni,
Since you have the CPU information in MADT.GICC and the PPTT table, it should be possible to use the SSDT CPU generator to create the AML description for the CPUs. This patch series can
|
By
Sami Mujawar
·
#84467
·
|
|
Re: EDK2 CI build error "Uncrustify Coding Standard"
Hi Brijesh,
A Tianocore wiki article is being prepared but the background and instructions for what to do were sent in this mail regarding the hard freeze being lifted -
Hi Brijesh,
A Tianocore wiki article is being prepared but the background and instructions for what to do were sent in this mail regarding the hard freeze being lifted -
|
By
Michael Kubacki
·
#84466
·
|
|
Re: [edk2-platforms][PATCH V1 03/11] Platform/ARM/Morello: Add PlatformDxe for Morello SoC
Hi Chandni,
Please find my feedback inline marked [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI] One print format specifier appears to be
Hi Chandni,
Please find my feedback inline marked [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI] One print format specifier appears to be
|
By
Sami Mujawar
·
#84465
·
|
|
Re: [edk2-platforms][PATCH V1 02/11] Platform/ARM/Morello: Add Platform Library support for Morello SoC
Hi Chandni,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
With that updated,
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI] I think the
Hi Chandni,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
With that updated,
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI] I think the
|
By
Sami Mujawar
·
#84464
·
|
|
Re: [edk2-platforms][PATCH V1 01/11] Platform/ARM/Morello: Rename PlatformLib.inf file
Hi Chandni,
Thank you for this patch.
I think the following change from "[edk2-platforms][PATCH V1 05/11] Platform/ARM/Morello: Add initial support for Morello SoC" should be part of this patch.
Hi Chandni,
Thank you for this patch.
I think the following change from "[edk2-platforms][PATCH V1 05/11] Platform/ARM/Morello: Add initial support for Morello SoC" should be part of this patch.
|
By
Sami Mujawar
·
#84463
·
|
|
Re: Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #5 - Completed - Hard Freeze Lifted
I will send a patch for the Tianocore Wiki shortly.
Thanks,
Michael
I will send a patch for the Tianocore Wiki shortly.
Thanks,
Michael
|
By
Michael Kubacki
·
#84462
·
|
|
EDK2 CI build error "Uncrustify Coding Standard"
Hi All,
I am rebasing the SNP series and encountering the error like below from the CI. I am not sure what I am missing. For testing purpose, I just tried one commit and CI Windows build complains
Hi All,
I am rebasing the SNP series and encountering the error like below from the CI. I am not sure what I am missing. For testing purpose, I just tried one commit and CI Windows build complains
|
By
Brijesh Singh
·
#84461
·
|
|
Re: [EXTERNAL] RE: [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg : Support for Junction City Platform.
Manic,
Please move UBA Junction City specific content into JunctionCity folder. We should do the same for the different RVP boards as well. The MinPlatform design goal is to have the shared code
Manic,
Please move UBA Junction City specific content into JunctionCity folder. We should do the same for the different RVP boards as well. The MinPlatform design goal is to have the shared code
|
By
Oram, Isaac W
·
#84460
·
|
|
Re: Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #5 - Completed - Hard Freeze Lifted
Mike,
How is this documented outside of this patch set? Is there a Tianocore Wiki page on configuring uncrustify? Does that Readme.rst link to that?
Thanks,
Andrew Fish
Mike,
How is this documented outside of this patch set? Is there a Tianocore Wiki page on configuring uncrustify? Does that Readme.rst link to that?
Thanks,
Andrew Fish
|
By
Andrew Fish
·
#84459
·
|
|
Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #5 - Completed - Hard Freeze Lifted
Hello,
Thank you to everyone for their patience and for everyone who helped with the development
and review of this important update to the edk2 repository.
The last 2 PR series have completed
Hello,
Thank you to everyone for their patience and for everyone who helped with the development
and review of this important update to the edk2 repository.
The last 2 PR series have completed
|
By
Michael D Kinney
·
#84458
·
|
|
Re: [EXTERNAL] RE: [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg : Support for Junction City Platform.
Isaac :
Thank you for your review comments. Please see the inline response and provide your comments if there is any.
Isaac :
Thank you for your review comments. Please see the inline response and provide your comments if there is any.
|
By
manickavasakam karpagavinayagam
·
#84457
·
|
|
[edk2platforms][PATCH v4 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol
Added IntelDieInfo header into IntelSiliconPkg tree.
The purpose is to have generic and unified interface for getting
information about dies installed in the system.
It will be implemented by silicon
Added IntelDieInfo header into IntelSiliconPkg tree.
The purpose is to have generic and unified interface for getting
information about dies installed in the system.
It will be implemented by silicon
|
By
Maciej Czajkowski
·
#84456
·
|
|
[edk2platforms][PATCH v4 0/1] IntelSiliconPkg: Add IntelDieInfoProtocol
This commit will add a protocol/PPI definition which will provide a generic and
unified way to get information about dies installed in the system(PCH, SoC, CPU).
It will be implemented per generation
This commit will add a protocol/PPI definition which will provide a generic and
unified way to get information about dies installed in the system(PCH, SoC, CPU).
It will be implemented per generation
|
By
Maciej Czajkowski
·
#84455
·
|
|
Re: Uncrustify Conversion Detailed Plan and Extended Hard Freeze Update #4
Hi Mike,
Thanks a lot for these changes.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
On 06/12/2021, 01:18, "devel@edk2.groups.io on behalf of Michael D Kinney via
Hi Mike,
Thanks a lot for these changes.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
On 06/12/2021, 01:18, "devel@edk2.groups.io on behalf of Michael D Kinney via
|
By
Sami Mujawar
·
#84454
·
|
|
[PATCH v2 2/4] IntelSiliconPkg/VTd: Update VTd register structs
Update VTd register structs accroding to VTd spec ver 3.3
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3765
Cc: Rangasai V Chaganty <rangasai.v.chaganty@...>
Cc: Jenny Huang
Update VTd register structs accroding to VTd spec ver 3.3
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3765
Cc: Rangasai V Chaganty <rangasai.v.chaganty@...>
Cc: Jenny Huang
|
By
Sheng Wei
·
#84453
·
|
|
[PATCH v2 4/4] IntelSiliconPkg/VTd: Only generate PEI DMA buffer once.
VTdInfoNotify may be called manay times, PEI DMA buffer should be
generated only once.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3667
Cc: Rangasai V Chaganty
VTdInfoNotify may be called manay times, PEI DMA buffer should be
generated only once.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3667
Cc: Rangasai V Chaganty
|
By
Sheng Wei
·
#84452
·
|
|
[PATCH v2 1/4] IntelSiliconPkg/VTd: Fix typos
It is DRHD(DMA Remapping Hardware Unit Definition).
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3622
Cc: Rangasai V Chaganty <rangasai.v.chaganty@...>
Cc: Jenny Huang
It is DRHD(DMA Remapping Hardware Unit Definition).
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3622
Cc: Rangasai V Chaganty <rangasai.v.chaganty@...>
Cc: Jenny Huang
|
By
Sheng Wei
·
#84451
·
|
|
[PATCH v2 3/4] IntelSiliconPkg/VTd: Support VTd Abort DMA Mode
If VTd ECAP_REG.ADMS bit is set, abort DMA mode is supported.
When VTd Abort DMA Mode is enabled, hardware will abort all DMA
operations without the need to set up a root-table with each
entry
If VTd ECAP_REG.ADMS bit is set, abort DMA mode is supported.
When VTd Abort DMA Mode is enabled, hardware will abort all DMA
operations without the need to set up a root-table with each
entry
|
By
Sheng Wei
·
#84450
·
|
|
[PATCH v2 0/4] There are 4 patches for VTd drivers
[PATCH 1/4] IntelSiliconPkg/VTd: Fix typos
[PATCH 2/4] IntelSiliconPkg/VTd: Update VTd register structs
[PATCH 3/4] IntelSiliconPkg/VTd: Support VTd Abort DMA Mode
[PATCH 4/4] IntelSiliconPkg/VTd:
[PATCH 1/4] IntelSiliconPkg/VTd: Fix typos
[PATCH 2/4] IntelSiliconPkg/VTd: Update VTd register structs
[PATCH 3/4] IntelSiliconPkg/VTd: Support VTd Abort DMA Mode
[PATCH 4/4] IntelSiliconPkg/VTd:
|
By
Sheng Wei
·
#84449
·
|