Hi, Hmm, wouldn't it be better to create and use the PlatformInfo for both PEI-based and PEI-less boot? We would not need that kind of checks in the first place then. take care, Gerd

Reminder: TianoCore edk2-test Bug Triage Meeting When: 01/27/2022 10:00pm to 11:00pm (UTC+08:00)

Quite some code duplication here ... ... and possibly more. I think these functions should move to the new PlatformInitLib too. take care, Gerd

With this being more widely used it doesn't make sense to have it in IntelTdx.h ... take care, Gerd

Now you have the CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER twice ... take care, Gerd

Why have both PcdSevEsWorkAreaBase and PcdTdxWorkAreaBase when we have a shared work area? take care, Gerd

Given you are mostly moving code around as git noticed ... ... it doesn't make sense to split that into two patches. Just using "git mv" instead has the additional advantage to keep the git history

<michael.d.kinney@...> wrote: Acked-by: Ard Biesheuvel <ardb@...>

Acked-by: Gerd Hoffmann <kraxel@...>

Hi, So, what is the plan for this with pei-less boot? I think we should move this to PlatformInitLib, then link either into PlatformPei or the early dxe module for pei-less boot? take care, Gerd

Acked-by: Gerd Hoffmann <kraxel@...>

https://www.suse.com/c/revolutionizing-arm-technology-x86_64-option-rom-aarch64/ https://www.workofard.com/2020/12/aarch64-option-roms-for-amd-gpus/

Merged.

This is the PR: https://github.com/tianocore/edk2/pull/2444

Reviewed-by: Abner Chang <abner.chang@...> Please create a PR (give me the link) for running Core CI, I will merge it once it gets passed through. Thanks Abner

Sure. The standalone patch is sent out. PR: https://github.com/tianocore/edk2/pull/2444

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3814 CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. But the second parameter of UefiDecompressGetInfo() is declared

Reviewed-by: Ray Ni <ray.ni@...>

Hi Michael, Thanks for your response. Sorry I didn't give enough context for my question, I mean the ' SizeOfInitializedData' in Optional header of PE-COFF file. SizeOfInitializedData The size of

Hi Steven, I'd suggest appending the threads number to the --jobs FLAG. The threads number can be got via build.py ThreadNum(), and suggest testing the incremental build functionality.