REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3829 Commit cbc8e420ac4505e9c51aa0d4f049026691024ca5 caused GCC build failure which should be fixed. Cc: Nate DeSimone

Mike, Yea I’m thinking this is a good reason to maybe not add more knobs. I was trying to get tricky and have code conditionally use a global so I could use the lib XIP when I shot myself in the

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3840 Use DEBUG_FILE to control ASSERT path Motivation and Goal: 1. The path will occupy many size in DEBUG build when file path is long 2. We hope

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3840 Use DEBUG_FILE to control ASSERT path Motivation and Goal: 1. The path will occupy many size in DEBUG build when file path is long 2. We hope

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3840 1. Use DEBUG_FILE to control ASSERT path 2. Default use file name as ASSERT path Motivation and Goal: 1. The path will occupy many size in

Inline comments below:

Acked-by: Hao A Wu <hao.a.wu@...> I recommend to get Ray's input for this patch before merging. Best Regards, Hao Wu

Inline comments below:

Dear maintainers, Could you review this patch? Thanks, heng

Fix pushed: https://github.com/tianocore/edk2-platforms/commit/cbc8e420ac4505e9c51aa0d4f049026691024ca5 Thanks, Chasel

Hi Andrew, I forgot about the library constraints. Unless we want to first add a feature to build a library instance for each module type into a different build output directory, we cannot

I shot my self in the foot with the Fixed* macro in a library so I did not get the drivers override. So I feel that pain. You need to used the non Fixed form from a lib to get the value from the

Andrew, It is a reasonable ask, but I lean towards voting no. We can more or less do the equivalent by breaking a monolithic build into a set of phase specific build/DSC/FDF or something similar.

Thanks Nate, Isaac for good catch! I will correct them before pushing.

Hi Chasel, There are a couple of typos and minor code style issues pointed out below. Please fix those during the push... no need to send another patch. Reviewed-by: Nate DeSimone

Well it does seem like a reasonable thing to be able to do? What do other people think? I was able to refactor my code and I did not actually end up needing to override every PEIM and the PEI

I agree that your approach is the only way right now. Do you have a feature request??? Mike

Hi Kun, The EDK II Code First Process says the branch should be against the edk2-staging repo. Your patches are for the edk2 repo. Mike

This vendor specific device driver implementation does not seem to fit into UEFI payload package scope well. Do you think https://github.com/tianocore/edk2-platforms/tree/master/Silicon could be a

From: Patrick Rudolph <patrick.rudolph@...> Uses the RDRAND instruction if available and install EfiRngProtocol. The protocol may be used by iPXE or the Linux kernel to gather entropy. Cc: