Reviewed-by: Ray Ni <ray.ni@...>

Reviewed-by: Ray Ni <ray.ni@...>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2668 WindowOpen will fail in some case. for example, without XServer. Shouldn't set ModeInfo in this case to avoid the caller use

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2668 SetMode will fail in some case. for example, without XServer. Should handle these case when SetMode fail. If we don't handle it, it will

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2668 Correct the logic to handle the case that XServer not present to avoid Segmentation fault V2: Fix typo error. Guomin Jiang (2):

Or I can simply do 1 and 2, but leave 3,4,5 so that I don't make everything more complex. I mean I don't really need the FVMAIN_SIZE to be larger, and by keeping it the way it is (both VARS_SIZE

Ok Ok Ok. Do you want me to keep the factorization in VarStore.fdf.inc? Ok Ok I'll check how feasible this is. --------------------------------------------------------------------- Intel Corporation

From: MingYue Liang <mingyuex.liang@...> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2988 In FDF file, if INF key word is wrongly written as INT, build tool will report the execption.

Please do not change the lib API name. You can choose a different name for driver internal function.

1. InitializeSmmCpuServices(): please keep the ASSERT_EFI_ERROR (Status) for CpuService protocol installation. Will add assert. 2. SmmWaitForApArrival (): Can you remove the BlockingMode parameter

1. InitializeSmmCpuServices(): please keep the ASSERT_EFI_ERROR (Status) for CpuService protocol installation. 2. SmmWaitForApArrival (): Can you remove the BlockingMode parameter because I cannot

Move intrinsics for ia32 from CryptoPkg/Library/IntrinsicLib to MdePkg/Library/CompilerIntrinsicsLib. Also move strcmp. Remove CryptoPkg/Library/IntrinsicLib. Use

This is an attept to start cleaning up the messy compiler intrinsics situation. Today we don't have a core intrinsics library, resulting in everybody creating their own. ArmPkg has one, CryptoPkg

Update #if contitions so the the 64bit version is picked for X64 too. Signed-off-by: Gerd Hoffmann <kraxel@...> --- MdePkg/Library/CompilerIntrinsicsLib/memcmp_ms.c | 2 +-

First step in creating a single, common compiler intrinsics library for everybody who needs it. Move the ArmPkg library to MdePkg, update all references. No code changes. Signed-off-by: Gerd

Reviewed-by: Ray Ni <ray.ni@...>

I think you can: (1) drop FD.CLOUDHV_VARS (2) drop FD.CLOUDHV_CODE (3) make VARS_SIZE smaller (just enough for the pvh header), (4) make FVMAIN_SIZE larger (so the total size remains the

Abner, UefiCpuPkg\SecCore\SecCoreNative.inf is a module that might not depend on X86. It assumes the UefiCpuPkg/ResetVector inits the CPU well. UefiCpuPKg/BaseUefiCpuLib 1. Rename

Reviewed-by: Ray Ni <ray.ni@...>

Reviewed-by: Ray Ni <ray.ni@...>