(1) Please mention the following in the commit message: ------- This patch ports (parts of) the following commits to ArmVirtQemu: - 3103389043bd ("OvmfPkg: Add TCG2 Configuration menu to the Device

This should not be needed. Or more precisely, not like this. In OvmfPkg, Marc-André added TPM2 PPI support in the following series (which was separately building upon the initial TPM2 enablement):

Agree Nate. Reviewed-by: Chasel Chiu <chasel.chiu@...> Thanks, Chasel

OK I'm not sure about OVMF, but according to SecurityPkg.dec's description of this PCD (line 455): # If all the bits are clear, that means hash algorithm is determined by current Active PCR

I'm OK with this patch; I have two requests: (1) Please add the following to the commit message: ----- This patch ports (parts of) the following OvmfPkg commits to ArmVirtQemu: - 6cf1880fb5b6

Reviewed-by: Laszlo Ersek <lersek@...>

Thanks for the update! Acked-by: Laszlo Ersek <lersek@...> Laszlo

The series has been pushed as 9227724a..c6ed9b2d

Pushed: https://github.com/tianocore/edk2-platforms/commit/974ddebcf191e32c5eb2f52e5ef85423f4de9819

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Mike: Current solution is to define the flexible structure array with zero. This style is supported by VS/GCC/CLANG compiler. StructurePcd also uses this solution (here is my example

Liming, This does not make sense. Those compilers should support C99 flexible array members. Structured PCDs also require use of flexible array members. We need to make sure the compiler flags

Mike: I find this issue on GCC5 tool chain tag with GCC 5.5 and CLANGPDB tool chain tag with CLANG 9.0.0 Thanks Liming

Leo and all, I replied in https://bugzilla.tianocore.org/show_bug.cgi?id=2556 for a more general question about how uCode is used in AMD processors. Because this package recently exposed a new

Which GCC and CLANG tool chain tags? Flexible array member is a standard C feature documented in C99. Mike

Mike: I find GCC and CLANG will report the error for the empty struct. d:\allpkg\edk2-platforms\Silicon\Intel\IntelSiliconPkg\Include\Guid/MicrocodeShadowInfoHob.h:61:11: error: flexible array

What compiler does not like the flexible array member syntax []. Mike

Reviewed-by: Ray Ni <ray.ni@...>

For the patch series... Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Hi Pankaj, Assuming that your other patch (https://edk2.groups.io/g/devel/message/54629) is approved and merged to edk2, this patch looks good at least for the Intel platforms. Once