... I realize I didn't make the same comment for GhcbIsRegValid(), so I'm taking back the above -- consistency with GhcbIsRegValid() is more important. No change needed here. Acked-by: Laszlo Ersek

Acked-by: Laszlo Ersek <lersek@...>

(1) I suggest improving the consistency of operators -- please either use division and remainder ("Offset / 8" and "Offset % 8"), or bit shift and masking ("Offset >> 3" and "Offset & 0x7") With

Hi Tom, This patch modifies both MdePkg and OvmfPkg. I agree that, as an exception, this is the right thing to do. That's because we are not changing the identifiers of the enumeration constants

Hi Tom, please file a TianoCore BZ for this series, assign it to yourself, link the v1 posting in a comment on the BZ, and update the commit messages to reference that BZ. I find this relevant

From: Maggie Chu <maggie.chu@...> https://bugzilla.tianocore.org/show_bug.cgi?id=3D3004 Secure erase is performed by generating a new encryption key, this is only available if encryption is

Thank you. I have no more ideas or questions. Please proceed as you suggested. Laszlo

Reviewed-by: Liming Gao <gaoliming@...> supports.

Thanks Sean. CI test for RedfishPkg is merged @19c87b7d446c3273e84b238cb02cd1c0ae69c43e

Reviewed-by: Sean Brogan <sean.brogan@...> Thanks

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3007 Currently UsbDevContext is not cleaned up if USB slot initialization is failed, the wrong context data will affect next USB devices and the

Hi Ray, Could you please help to push this patch to edk2-platform? Thanks. Best, Aaron

Just learned that from Liming, one of the maintainers can just create PR for the reviewed-by patch set and merge the patches even he/she is just one of maintainers in that set of patches. I will

Patches were merged @b9b7406c43e9d29bde3e9679c1b039cb91109097

This patch was pushed at f6d0a6fe01

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

When cloning a repo the files do not need to be checked out. This is because files will be checked out based on information in the manifest later. This reduces a number of file operations on larger

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 Adding the auto-generated assembly files for X64 architectures. Cc: Jian J Wang <jian.j.wang@...> Cc: Xiaoyu Lu

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 Adding OpensslLibX64.inf and modifying process_files.pl to process this file and generate the necessary assembly files. ApiHooks.c contains a

V3 Changes: Added definitions for ptrdiff_t and wchar_t to CrtLibSupport.h for LLVM/Clang build support. Added -UWIN32 to GCC Flags for LLVM/Clang build support. Added missing AES GCM