From: Ilias Apalodimas <ilias.apalodimas@...> A following patch is adding support for building StMM in order to run it from OP-TEE. OP-TEE in combination with a NS-world supplicant can use the

This patch series is adding a platform definition for compiling StMM as a flash image, which we can run from OP-TEE. SPM (responsible for dispatching StMM) and SPD (for OP-TEE) are mutually exclusive

Hi Rebecca, Please add doxygen function header for ArmIsCcidxImplemented(). With that added: Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Leif, I had a similar observation while reviewing the code. Please see my response inline below marked [SAMI]. Regards, Sami Mujawar

Hi Rebecca, Please add doxygen style function documentation for ArmReadIdMmfr4(). With that added: Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Mike, That’s right. And due to that interface being vendor-specific, Intel controllers work fine. I am not positive more logic is needed since it is opt-in. These patches are not new, and so far

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3036 MinDsdt is missing a LibraryClasses dependency for MemoryAllocationLib,so I add it for this. Cc:Chasel Chiu <chasel.chiu@...> Cc:Nate

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3034 The duplicated FILE_GUIDS in several files have been changed to make their GUids unique Cc:Chasel Chiu <chasel.chiu@...> Cc:Nate

The comment at the top of this file (not visible in this diff) also mentions "SEV Launch Secret" which should be renamed to "Confidential Computing Secret". -Dov

Hi Abner, I got it. These two interfaces are defined in library so that platform library has to implement it. This makes sense to me. Reviewed-by: Nickle Wang <nickle.wang@...> Thanks, Nickle

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3035 Several new LibraryClasses are missing from MinPlatformPkg.dec, so i add some new interfaces. Signed-off-by: Jiwei Wei

Hi Enze, Please remove the "Reviewed-by:" from the code review mail. Reviewer need to reply the code review mail with Reviewed-by. Thanks, Bob

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3122 Adding "-LF"/"-lf" option to support slot mode without FFS GUID check. It will support the scenario that multiple Microcode FV with different

Done. Fix in next set of patches.

We had a build fail due to the hard coded MAX_LONG_FILE_PATH value. We should use PATH_MAX if it is available. Cc: Bob Feng <bob.c.feng@...> Cc: Liming Gao <gaoliming@...> Cc: Yuwei

Hi Liming, So the PCD TOKEN is still useful for static PCD. For the sentence of "AutoGen.h will not be changed when PCD is added or removed.", I think if a user adds or deletes a dynamic PCD, the