From: Michael Kubacki <michael.kubacki@...> Adds a new component called SpiFvbServiceStandaloneMm that serves as a Standalone MM compatible SPI FVB service driver. Note that a

Mike, I agree the UNI file should be strict. I was also thinking about comments, build config files etc? Is there a definition of what is legal in a comment? The code that had the crazy characters

Hi Mike, I'm planning to put up a branch that we can use as a reference for a conversation around uncrustify in the next couple of weeks. Thanks, Michael

Trusted console is required for TCG Physical Presence and only trusted console could be connected before EndOfDxe. Since TCG Physical Presence is not enabled yet in the UefiPayloadPkg, I think it is

Hi Bret, Please share the proposed adjustments. If we can use a well supported tool that allows us to remove the C parser from ECC, then I think that would be a big improvement. Mike

Acked-by: Ard Biesheuvel <ardb@...>

I found a couple of extensions for Visual Studio Code that will highlight bad characters. "Highlight Dodgy Characters" seems to do the trick. Sorry about that AMD Official Use Only thing. The

Reviewed-by: Maurice Ma <maurice.ma@...> Regards Maurice

@Desimone, Nathaniel L, I’m interested in mentorship for the GSC project. Would like to talk offline about potential projects and past experience. RE: ECC, we’re internally evaluating

My comment is only to make the history of changes easier to understand by separating the functional and non-functional changes. Mike

Thanks Heng for all the hard work! And thank you Nate for pushing the series.

Mike, The clean up doesn’t cause any final instruction change and I have verified that. The reason I put the fix in last because the Lock field is not needed with the fix but removing the Lock

The series has been pushed as d55602c~..ee33d4f Thanks Again Heng!

Hi Ray, I really like the cleanup to remove hard coded offsets, but I think that change should be its own patch series. Can we make the functional change to use XADD as its own patch series before

One I know the file path, I usually use a Notepad++ feature: Search-> Find Chars In Range-> Non ASCII Mike

Hi Ankur, I figure it's prudent for me to follow up here too: Please *do* add the volatile, and also the MemoryFence(). When built with Visual Studio, MemoryFence() does nothing at all (at least

I'll let others review this patch. I'm OK to add macros to the nasm.inc files under MdePkg, as wrappers for the DB-encoded CET instructions, as long as you also file a reminder BZ to replace the DBs

Reviewed-by: Laszlo Ersek <lersek@...>

[AMD Official Use Only - Internal Distribution Only] 0x9d is one of those pesky "smart quotes" many applications love to use. These are the double quote or single quote characters that slant left and

Reviewed-by: Laszlo Ersek <lersek@...>