Well, the problem with the "do it later" approach is that these tasks then tend to fall down to the bottom of the TODO list ... take care, Gerd

Hi all, I just delete Trailing whitespaces of a blank line in this version of patch. Besides, this script has been tested and can successfully build UniversalPayload on both windows and

V1: Add script to build UniversalPayload, which can be used after edksetup rebuild The final UPL.elf will be located at root folder of edk2 V2: Revise the ouput directory of generated files and

SEC checks in IsSevGuest if the PCD defined WorkAreaHeader size matches the size of the WorkAreaHeader struct definition. Set a default value for the PCD to avoid unnecessary DSC/FDF file changes in

Hi, I guess TDX needs to do that too? Should we pick more generic names for the PCDs then? take care, Gerd

Reviewed-by: Jiewen Yao <Jiewen.yao@...>

Already done in SEC phase (patch #9), why again in PEI? thanks, Gerd

Hi, A comment explaining those GHCBv1 vs. GHCBv2 differences would be great. thanks, Gerd

Hi, Hmm, TDX will re-use those pages for something else. So as long as TDX is happy with OVMF_SECTION_TYPE_SEC_MEM everything should work fine and just mentioning that in the comments will be

Hi, Pointer to the struct spec would be nice here, take care, Gerd

I think we should use the same approach (and the same enum) we are planing to use for the ConfidentialComputing PCD (see discussion in the other patch series). take care, Gerd

So a "save space in MEMFD" vs. "be future proof" tradeoff. Any plans to actually do that? Defining an 64-bit entry point is a more than just using 64-bit addresses. For starters long mode requires

Currently the realpath is used when parse modules, which shows the path with a drive letter in build log. In Windows 'subst' comand is used to associates a path with a drive letter, when use the

On Thu, Sep 16, 2021 at 02:14 PM, Ni, Ray wrote: FeatureInitData = &mAcpiCpuData.CpuFeatureInitData;Hi Ray, Yes, agree with you, I will remove the code blow. if (FeatureInitData == NULL) {

SEC checks in IsSevGuest if the PCD defined WorkAreaHeader size matches the size of the WorkAreaHeader struct definition. Set a default value for the PCD to avoid unnecessary DSC/FDF file changes in

+ FeatureInitData = &mAcpiCpuData.CpuFeatureInitData; + if (FeatureInitData == NULL) { 1. It's impossible for FeatureInitData == NULL. With this check removed, Reviewed-by: Ray Ni

Ashraf, The layout of binary files looks good to me. The Build.py generates the IA32 binary twice which is unnecessary. But I think it's acceptable. Reviewed-by: Ray Ni <ray.ni@...>

Reviewed-by: Chasel Chiu <chasel.chiu@...>

Amy, No. We only Add QuickSort() function API into BaseLib.h.

Andrew, Liming, I think your idea works better. UefiCpuPkg à MdePkg (BaseLib) xxxPkgà MdeModulePkg (SortLib)à MdePkg (BaseLib) Gradually we will eliminate the MdeModulePkg (SortLib)