The series has been pushed as d55602c~..ee33d4f Thanks Again Heng!

Hi Ray, I really like the cleanup to remove hard coded offsets, but I think that change should be its own patch series. Can we make the functional change to use XADD as its own patch series before

One I know the file path, I usually use a Notepad++ feature: Search-> Find Chars In Range-> Non ASCII Mike

Hi Ankur, I figure it's prudent for me to follow up here too: Please *do* add the volatile, and also the MemoryFence(). When built with Visual Studio, MemoryFence() does nothing at all (at least

I'll let others review this patch. I'm OK to add macros to the nasm.inc files under MdePkg, as wrappers for the DB-encoded CET instructions, as long as you also file a reminder BZ to replace the DBs

Reviewed-by: Laszlo Ersek <lersek@...>

[AMD Official Use Only - Internal Distribution Only] 0x9d is one of those pesky "smart quotes" many applications love to use. These are the double quote or single quote characters that slant left and

Reviewed-by: Laszlo Ersek <lersek@...>

Reviewed-by: Laszlo Ersek <lersek@...>

Hi Pierre, This patch looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

There is no code change in this file. Can you exclude the changes in this file from the patch, please? With that changed: Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Thank you for this patch. Reviewed-by: Sami Mujawar <sami.mujawar@...> Regards, Sami Mujawar

Hi Pierre, There should be a single trailing underscore for #include guards. See

After checking Bugzilla 3187, NVRAM already corrupted in this case. Sorry that I didn’t aware.

Do you mean that you have set up an infinite loop in which UEFI loads ipxe.efi which loads ipxe.efi which loads ipxe.efi which loads ipxe.efi etc....? If so, then my guess is that you are simply

Hi Sami,

Would you please add comment on why we need reserve and program the 8 bytes here? Something like: // // The highest address on the stack (0xFF8) is a save-previous-ssp token pointing to a location

Hi Jiewen, Eric, Ray, Rahul, Ersek, I have updated the patch v2. And all comments are fixed. Since open CI is using NASM 2.14.02, it has not supported CET instructions yet. I would like to use DB xx

If CET shadows stack feature enabled in SMM and stack switch is enabled. When code execute from SMM handler to SMM exception, CPU will check SMM exception shadow stack token busy bit if it is cleared