Cole: Here is the error message https://edk2.groups.io/g/devel/message/80068?p=,,,20,0,0,0::recentpostdate%252Fsticky,,python,20,2,0,85296733 Yes, Python27 has been end of life. But, Edk2 has

Kuo: I suggest to move SORT_COMPARE definition from MdeModulePkg\Include\Library\SortLib.h to MdePkg\Include\Library\BaseLib.h, and then let SortLib.h include BaseLib.h. Thanks Liming does

Reminder: TianoCore Community Meeting - APAC/NAMO When: 10/07/2021 7:30pm to 8:30pm (UTC-07:00) America/Los

Samer: Thanks for your information. I agree this change. Reviewed-by: Liming Gao <gaoliming@...> Thanks Liming

We did investigate this in the BZ, and the conclusion was it is safer to update the code to match the spec. The only OS implementation we have seen so far is in Linux, and it uses the spec defined

Reviewed-by: Dandan Bi <dandan.bi@...> Thanks, Dandan

Reviewed-by: Dandan Bi <dandan.bi@...> Thanks, Dandan

Jones: Do you know what impact will be introduced by this change? Thanks Liming

I propose to submit independent patch with independent metadata (2 tables) – don’t complicate thing. We can revisit to see if there is need to merge to 1 table or how to merge, as a

From: IanX Kuo <ianx.kuo@...> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3675 Add QuickSort function into BaseLib Cc: Michael D Kinney <michael.d.kinney@...> Cc: Liming Gao

From: IanX Kuo <ianx.kuo@...> First change 1. MdePkg/BaseLib: Add QuickSort function It need to seperate to second change 2. MdeModulePkg/SortLib: Use QuickSort instead of QuickSortWorker 3.

Marvin, Good point. This would make the rule moot. So maybe just removing the requirement would be the easiest long term fix. Other embedded projects I know of do this too, and as you point out the

Hey Mike, Hey Andrew, I'll just reply to both mails at once :) Thanks! I'd keep STATIC actually just for the sake of not doing no-op changes that do not really do anything and for consistency with

This issue is independent of CONST. I’m not sure a coding style tool is smart enough to catch this generically? You need an understanding of C types to know if the local variable assignment is going

Hi Marvin, Some comments below. Mike

Hi Leif, Thanks for the feedback. Adjusting the EDK II C Coding Style should absolutely be part of this discussion. We need to work towards specific proposals. Here are the current open bugs

Thanks Mike, I will look into that. For others, I recently published an "uncrustify_poc_3" branch on my edk2 fork that demonstrates the latest set of results I've obtained with Uncrustify tool

Hi Michael, I am looking at your uncrustify_poc_3 branch, and I see an unexpected change related to use of IN/OUT in a function declaration. File: MdeModulePkg\Logo\Logo.c Before

Good day, +1, but while you're at it, can we have arguments not align to the function name... Status = Test ( a ); ... but to the next natural indentation level?

On the git-blame front we might be able to build a recipe that walks past the code style and line ending commits that would could add to an FAQ or Wiki. For bonus points we could add a git command