Making baselib implementation depend on MemoryAllocationLib (indirectly on Pei Service and gBS), it may prevent this base API using at some seneraio. i don't think it's better. Add this parameter and

Hi Ray, In this patch, we added a shared file AcpiTable.c for both universal payload and non-universal payload. The exposed API from this file is: EFI_STATUS BuildHobFromAcpi ( IN UINT64

Hey Ray, In my opinion that spec is too complicated. For some cases it is obvious, but I think the last anyone wants to see is a (STATIC_)ASSERT before most QuickSort calls to ensure the element size

Reviewed-by: Ray Ni <ray.ni@...>

- Status = ParseMemoryInfo (MemInfoCallbackMmio, &AcpiBoardInfo); + Status = ParseMemoryInfo (MemInfoCallbackMmio, NULL); Guo, I am curious why you changed this part. Without this change,

Hi Ray, I have no comments. Thanks, Dun

Reviewed-by: Ray Ni <ray.ni@...>

Liming, The purpose of the optional BufferOneElement is to ease consumer’s life assuming most of the time the element size should be smaller than 256. Are you saying that it’s a bit hard to

Reviewed-by: Ray Ni <ray.ni@...> Dun, any comments?

Ray: I may suggest to always require BufferOneElement. The consumer code may not know ElementSize. To avoid the error, the consumer must allocate buffer for BufferOneElement. If so,

Reminder: TianoCore Design Meeting - APAC/NAMO When: 10/01/2021 9:30am to 10:30am (UTC+08:00) Asia/Shanghai Where: Microsoft Teams Organizer: Ray Ni ray.ni@... View

Yes. Agree. Good suggestion.

Zhichao: I am OK to use "..." as the end of string. I suggest to add the comments to explain the different behavior for BootManagerMenuApp and BootManagerUiLib in BZ. Thanks Liming

Jiewen: Thanks for this information. I suggest to add this URL into the file header comment, like Edk2\MdePkg\Include\IndustryStandard\DmaRemappingReportingTable.h. Thanks Liming

I recommend we start with 2 metadata and check in. It is working today for both SEV and TDX, with KVM and Cloud Hypervisor support. Thank you Yao Jiewen

Thanks for reminder. I have updated the patch-set as you mentioned. But I am waiting for a conclusion of the Metadata, a unified metadata or two separate metadata. Hoffmann and Jiewen Do we have a

From: Guo Dong <guo.dong@...> V2: Use LittleEndianStructure by review comment. From the universal scalable firmware payload requirement V0.75, Payload must have Universal Payload Information

Thanks for the comments. I will update the patch to add LittleEndianStructure. Thanks, Guo

From: Guo Dong <guo.dong@...> PCH SMM module would install SMM SW dispatch2 protocol. And it supports to register SMI handlers based on SMI APM interrupt from the bootloader information

From: Guo Dong <guo.dong@...> Add SMM variable support for universal UEFI payload. By default they are disabled. Signed-off-by: Guo Dong <guo.dong@...> ---