Hi Pierre, Thank you for your review and apologies for responding late. I was able to rework the patches and get a cleaner SSDT table implementation. I will post the patches soon. Please see my

Could I get some more reviews on this please? Thanks. Rebecca Cran

[AMD Official Use Only - General] Hi houjingyi, May I know why there are two messages with the same subject? Are these two identical? Thanks Abner

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 The implementation of TdxHelperProcessTdxHob is moved from PlatformInitLib/IntelTdx.c. Its counterpart in

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperBuildGuidHobForTdxMeasurement is called in PlatformPei to build GuidHob for Tdx measurement. Cc:

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperLib provides below helper functions for a td-guest. - TdxHelperProcessTdHob -

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 This patch enables Tdx measurement in OvmfPkgX64 with below changes: 1) TDX_MEASUREMENT_ENABLE is

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperBuildGuidHobForTdxMeasurement builds GuidHob for tdx-measurement which is measured in SEC phase.

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperBuildGuidHobForTdxMeasurement builds GuidHob for tdx-measurement which is measured in SEC phase.

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 2 new functions are added in PeilessStartupLib/IntelTdx.c. - BuildTdxMeasurementGuidHob -

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 FV_HANDOFF_TABLE_POINTERS2 once was defined in IntelTdx.c. Its structure is same as

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 After TdxHelperLib is instroduced, the SecMain.c in IntelTdx is updated with the new functions provided by

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperLib provides below helper functions for a td-guest. - TdxHelperProcessTdHob -

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperLib provides below helper functions for a td-guest. - TdxHelperProcessTdHob -

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 From the perspective of security any external input should be measured and extended to some registers (TPM

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 Tdx measurement (RTMR based measurement) is enabled in OvmfPkg/IntelTdx. This patch-set enables the feature in OvmfPkgX64 as well. Patch #1:

Might want to fix up the commit title from MdePkg to OvmfPkg before committing. Thanks, Tom

For the series, Reviewed-by: Ard Biesheuvel <ardb@...> Thanks a lot for your persistence. Queued as #3954

Ah, yes that sounds right. -- -Dionna Glaze, PhD (she/her)

Shouldn't this check be inside the if () below? Or are all resources that start at or above 4 GiB guaranteed to be system memory? No need to resend - if needed, I can fix that up when applying.