[AMD Official Use Only - General]

[AMD Official Use Only - General] Not the maintainer or reviewer, however Reviewed-by: Abner Chang <abner.chang@...>

Can you explain a bit more why this PCD is needed?

Hi Aryeh, Thank you for testing. Reviewed-by: Ankit Sinha <ankit.sinha@...>

Sorry, I forgot to ask this earlier in the series, but is StartAddress guaranteed to be page-aligned and Size a multiple of 4KB? Should there be any asserts for those just in case? Also, can Size be

(cc some other maintainers) Calling protocols is generally not permitted after ExitBootServices() anyway, so this statement is somewhat redundant. I'd clarify here is that it is the expectation that

Nate or Sai, this series should be a quick review if you could please prioritize… Benjamin, Your series is reviewed but breaks several builds due to unrelated changes. My plan is to get

Ultimately, ArmPkg has no justification for existing. It is a legacy of ARM support being added as a prototype, bolted onto the side of the rest of EDK2. Over time, it needs to be integrated into

Thank you Heng and all, My responses: 1. Fixed. 2. Fixed, it was a missed change now added to the new patch. 3. Added CC. Sending an updated patch file for reviewal. Thanks, Zack

From: Zachary Clark-Williams <zclarkw112@...> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845 Enables KVM and One Click Recovery WLAN capability with WiFi Profile Sync feature and

I am not following the logic here 100%. As far as I can tell, if accepting all memory succeeded without errors, ExitBootServices() returns with EFI_SUCCESS, even though it has modified the memory

Generally, we tend to rely on the DEC default for new PCDs if we're not deviating from it. If there is no specific reason to deviate from this here, I think we can drop this patch. Or is this also

The name PcdEnableUnacceptedMemory is a bit confusing imho. Could we rename this to PcdAcceptAllUnacceptedMemory or something like that?

<dionnaglaze@...> wrote: A signoff is an assertion by the contributor that the contribution is compatible with the license. It is *not* a statement of authorship. This means that you

Thanks, Isaac. Are these two S3 series ready to merge, or did I have more review to address?

Instead of eagerly accepting all memory in PEI, only accept memory under the 4GB address. This allows a loaded image to use the ENABLE_UNACCEPTED_MEMORY_PROTOCOL to indicate that it can interpret

Add a simple protocol that enables the use of the unaccepted memory type. Must be called before ExitBootServices to be effective. Cc: James Bottomley <jejb@...> Cc: Jiewen Yao

With the addition of the EfiUnacceptedMemory memory type, it is possible the EFI-enlightened guests do not themselves support the new memory type. This commit uses the new PcdEnableUnacceptedMemory to

The default value of PcdEnableUnacceptedMemory should be FALSE in order for default safe behavior. If the next started image does not yet understand UEFI v2.9's new memory type, then it's stuck with

This Pcd is used to toggle whether ExitBootServices should not accept all unaccepted memory. It's the loaded image's responsibility to enable support so that it doesn't get memory types it doesn't