|
Re: [Patch V2 2/2] UefiPayloadPkg: Remove clearing CR0.WP when protecting pagetable
Reviewed-by: Guo Dong <guo.dong@...>
Reviewed-by: Guo Dong <guo.dong@...>
|
By
Guo Dong
·
#92399
·
|
|
Re: [edk2-platforms][PATCH V1 3/3] PlatformPayloadFeaturePkg: Update contents to match feature conventions
Reviewed-by: Guo Dong <guo.dong@...>
Reviewed-by: Guo Dong <guo.dong@...>
|
By
Guo Dong
·
#92398
·
|
|
Re: [edk2-platforms][PATCH V1 1/3] PlatformPayloadPkg: Fix AdvancedFeaturePkg build issue
Reviewed-by: Guo Dong <guo.dong@...>
Reviewed-by: Guo Dong <guo.dong@...>
|
By
Guo Dong
·
#92397
·
|
|
Re: [edk2-platforms][PATCH V1 2/3] PlatformPayloadPkg: Rename to match other feature conventions
Reviewed-by: Guo Dong <guo.dong@...>
Reviewed-by: Guo Dong <guo.dong@...>
|
By
Guo Dong
·
#92396
·
|
|
Re: [edk2-platforms][PATCH V1 2/3] PlatformPayloadPkg: Rename to match other feature conventions
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@...>
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@...>
|
By
Chaganty, Rangasai V
·
#92395
·
|
|
Re: [PATCH] UefiCpuPkg/CpuPageTableLib/UnitTest: Add host based unit test
Hi Zhiguang,
Thank you for adding unit tests for this component.
I do want to make sure we are using consistent terminology related to different type of testing.
I think what you have implemented
Hi Zhiguang,
Thank you for adding unit tests for this component.
I do want to make sure we are using consistent terminology related to different type of testing.
I think what you have implemented
|
By
Michael D Kinney
·
#92394
·
|
|
Re: [edk2-platforms][PATCH V1 1/3] PlatformPayloadPkg: Fix AdvancedFeaturePkg build issue
Small cosmetic feedback. There is an (unnecessary) open "(" in line 145. Please remove it before checking in.
# (Optional for variable modules debug output
With that:
Reviewed-by: Sai Chaganty
Small cosmetic feedback. There is an (unnecessary) open "(" in line 145. Please remove it before checking in.
# (Optional for variable modules debug output
With that:
Reviewed-by: Sai Chaganty
|
By
Chaganty, Rangasai V
·
#92393
·
|
|
[PATCH V3] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported
Host Interface details are described by the SMBIOS Type 42 table.
The table is published by the RedfishHostInterfaceDxe driver.
That driver supports PCI-E and USB host interface types.
The table is
Host Interface details are described by the SMBIOS Type 42 table.
The table is published by the RedfishHostInterfaceDxe driver.
That driver supports PCI-E and USB host interface types.
The table is
|
By
Igor Kulchytskyy
·
#92392
·
|
|
Re: [PATCH] DynamicTablesPkg: Add support to build _DSD
Hi Jeff,
Please find some inline comments below:
I think this is DsdNode and PackageNode (same for the header file).
This is not consistent in the file, but it could be:
ASSERT_EFI_ERROR
Hi Jeff,
Please find some inline comments below:
I think this is DsdNode and PackageNode (same for the header file).
This is not consistent in the file, but it could be:
ASSERT_EFI_ERROR
|
By
PierreGondois
·
#92391
·
|
|
Re: [PATCH] UefiCpuPkg/CpuPageTableLib/UnitTest: Add host based unit test
Hi all,
This patch contains a big C file, containing random number to make it possible to reproduce issue in fuzzy test.
If the mail is hard to review, please review from
Hi all,
This patch contains a big C file, containing random number to make it possible to reproduce issue in fuzzy test.
If the mail is hard to review, please review from
|
By
Zhiguang Liu
·
#92390
·
|
|
[PATCH] UefiCpuPkg/CpuPageTableLib/UnitTest: Add host based unit test
Add host based unit tests for the CpuPageTableLib services.
Unit test focuses on PageTableMap function, containing two kinds of test
cases: manual test case and fuzzy test case.
Manual test case
Add host based unit tests for the CpuPageTableLib services.
Unit test focuses on PageTableMap function, containing two kinds of test
cases: manual test case and fuzzy test case.
Manual test case
|
By
Zhiguang Liu
·
#92389
·
|
|
Re: 回复: [edk2-devel] [PATCH] MdePkg:Improved Smbios Type9 table and Smbios 3.5.0 spec changes
ShellPkg is updated and reviewed(message:92383). Please help to review this patch and include in edk2-stable202208 tag.
ShellPkg is updated and reviewed(message:92383). Please help to review this patch and include in edk2-stable202208 tag.
|
By
Sainadh Nagolu
·
#92388
·
|
|
Re: [PATCH V2] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported
[AMD Official Use Only - General]
Three comments inline to coding standard.
[AMD Official Use Only - General]
Three comments inline to coding standard.
|
By
Chang, Abner
·
#92387
·
|
|
Re: [PATCH V2] RedfishPkg: Redfish third party modules may need to use the functions tat are currently private
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@...>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@...>
|
By
Chang, Abner
·
#92386
·
|
|
回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification
Sean:
According to the description, I agree with Pedro that this is a recommendation and not mandatory. Do you think so?
Thanks
Liming
发件人: devel@edk2.groups.io <devel@edk2.groups.io>
Sean:
According to the description, I agree with Pedro that this is a recommendation and not mandatory. Do you think so?
Thanks
Liming
发件人: devel@edk2.groups.io <devel@edk2.groups.io>
|
By
gaoliming
·
#92385
·
|
|
回复: [PATCH EDK2 v1 1/1] MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue
Agree this fix to add the check for this case. Reviewed-by: Liming Gao
<gaoliming@...>
Thanks
Liming
BitPerPixel
Agree this fix to add the check for this case. Reviewed-by: Liming Gao
<gaoliming@...>
Thanks
Liming
BitPerPixel
|
By
gaoliming
·
#92384
·
|
|
回复: [edk2-devel] [PATCH] ShellPkg:Improved Smbios Type 9 table changes in PrintInfo.c
Reviewed-by: Liming Gao <gaoliming@...>
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sainadh Nagolu via groups.io
发送时间: 2022年8月11日 19:44
收件人: Sainadh Nagolu
Reviewed-by: Liming Gao <gaoliming@...>
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sainadh Nagolu via groups.io
发送时间: 2022年8月11日 19:44
收件人: Sainadh Nagolu
|
By
gaoliming
·
#92383
·
|
|
Re: [PATCH] UefiPayloadPkg: Return PciRootBridges instead of NULL
Reviewd-by: Gua Guo <gua.guo@...>
Reviewd-by: Gua Guo <gua.guo@...>
|
By
Guo, Gua <gua.guo@...>
·
#92382
·
|
|
Re: [edk2-platforms] [PATCH 1/1] Platform/Sgi: Add support to disable isolated cpus
Hi Nishant,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 11/08/2022 02:46 pm, Nishant Sharma wrote:
[SAMI]
Hi Nishant,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 11/08/2022 02:46 pm, Nishant Sharma wrote:
[SAMI]
|
By
Sami Mujawar
·
#92381
·
|
|
Re: [edk2-platforms] [PATCH 1/1] Platform/Sgi: Add support to disable isolated cpus
Hey Sami,
This code is shared between all the variants of the Sgi platform.
Depending upon the variant, there will be a different number of CPUs present on it. To handle this I have written the code
Hey Sami,
This code is shared between all the variants of the Sgi platform.
Depending upon the variant, there will be a different number of CPUs present on it. To handle this I have written the code
|
By
Nishant Sharma
·
#92380
·
|