[AMD Official Use Only - General] Thanks Nickle. Two comments in the below.

Reviewed-by: Bob Feng <bob.c.feng@...>

Update EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL and add array type of value support to EDKII_REDFISH_VALUE in order to support ordered list op-code in HII. Modify corresponding function to support new

Hi Abner, Thanks for your review. I think I missed some parameter while using "git send-email" command. I will send out version 2 patch with issue fixed. Thanks, Nickle

[AMD Official Use Only - General] Hi Nickle, I found there are many redundant blank lines in the patch. Could you please check it? Thanks Abner

We shouldn't use direct casts, because in the future it could break the code, so using BASE_CR would be safe against possible structure changes and rearrangements Cc: Marvin Häuser

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677 Provided support for symlink file type. Added routine which allows reading and following them through recursive open() call. As a

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677 Hi all, In the third version I tried to correct all the remarks according detection logic of fast-symlink and its reading, code style and

Hello, Marvin! Thank you for your time and this code-review Yes, in this case we should capitalise L for camel-case style. I want to mention, that such code-style flaws present throughout entire

Add Konstantin Aladyshev to the copyright header. Signed-off-by: Konstantin Aladyshev <aladyshev22@...> --- BaseTools/Source/C/VolInfo/VolInfo.c | 1 + 1 file changed, 1 insertion(+) diff

Copyright (c) 2022, Konstantin Aladyshev <aladyshev22@...><BR> Will be fine. Thanks, Bob

Hi, Bob! How should I update it? Should I increase a year for the Intel Corporation like this ``` Copyright (c) 1999 - 2022, Intel Corporation. All rights reserved.<BR> ``` Or should I enter my name

Hi Konstantin, Could you update the copyright in VolInfo.c? Thanks, Bob

Reviewed-by: Bob Feng <bob.c.feng@...>

Hello everyone. I have a new exciting update about the project "Implement Rust-std for UEFI". It is now possible to run Rust Testing suit for UEFI under qemu. The instructions for running the tests

Reviewed-by: Bob Feng <bob.c.feng@...>

Reviewed-by: Bob Feng <bob.c.feng@...>

Reviewed-by: Bob Feng <bob.c.feng@...>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2639 Move Private calculation after TemporaryRamMigration to avoid calculate Private twice. RootCause: 1. ebp is used as Private pointer 2. It is

Signed-off-by: Benjamin Doron <benjamin.doron00@...> --- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/P= eiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 12