|
[edk2-platforms][PATCH v2 6/7] AmpereAltraPkg: Pipeline: Resolving newly introduced dependency
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
AmpereAltraPkg platforms
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
AmpereAltraPkg platforms
|
By
Kun Qin
·
#91675
·
|
|
[edk2-platforms][PATCH v2 5/7] Socionext: Pipeline: Resolving newly introduced dependency
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
DeveloperBox platforms
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
DeveloperBox platforms
|
By
Kun Qin
·
#91674
·
|
|
[edk2-platforms][PATCH v2 4/7] Qemu: Pipeline: Resolving newly introduced dependency
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
SbsaQemu platform builds.
Cc:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
SbsaQemu platform builds.
Cc:
|
By
Kun Qin
·
#91673
·
|
|
[edk2-platforms][PATCH v2 3/7] VExpressPkg: Pipeline: Resolving newly introduced dependency
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
ArmVExpress platforms
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
ArmVExpress platforms
|
By
Kun Qin
·
#91672
·
|
|
[edk2-platforms][PATCH v2 2/7] U5SeriesPkg: Pipeline: Resolving newly introduced dependency
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
U5SeriesPkg platforms
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
U5SeriesPkg platforms
|
By
Kun Qin
·
#91671
·
|
|
[edk2-platforms][PATCH v2 1/7] RaspberryPi: Pipeline: Resolving newly introduced dependency
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
RaspberryPi platforms
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
RaspberryPi platforms
|
By
Kun Qin
·
#91670
·
|
|
[edk2-platforms][PATCH v2 0/7] Resolving SecureBootVariableLib dependency
From: Kun <kuqin12@...>
This v2 series is a follow up of previously submitted patches:
https://edk2.groups.io/g/devel/message/91195
Compared to v1, v2 patches updated commit message to include
From: Kun <kuqin12@...>
This v2 series is a follow up of previously submitted patches:
https://edk2.groups.io/g/devel/message/91195
Compared to v1, v2 patches updated commit message to include
|
By
Kun Qin
·
#91669
·
|
|
Re: [PATCH 1/1] OvmfPkg/XenPvBlkDxe: Fix memory barrier macro
Ok, so the old MemoryFence() is definitely bogus here.
However, it doesn't need to be an mfence instruction. All that is
needed is smp_mb(), which these days is
asm volatile ( "lock addl $0,
Ok, so the old MemoryFence() is definitely bogus here.
However, it doesn't need to be an mfence instruction. All that is
needed is smp_mb(), which these days is
asm volatile ( "lock addl $0,
|
By
Andrew Cooper <Andrew.Cooper3@...>
·
#91668
·
|
|
Re: [edk2-platforms][PATCH 1/2] Ext4Pkg: Add symbolic links support
I think the code style demands "L" is capitalised.
<line break>
I think you can use "@returns Whether file is a symlink", because strictly speaking you would require a "FALSE" case with this
I think the code style demands "L" is capitalised.
<line break>
I think you can use "@returns Whether file is a symlink", because strictly speaking you would require a "FALSE" case with this
|
By
Marvin Häuser <mhaeuser@...>
·
#91667
·
|
|
Re: [edk2-platforms][PATCH v2 1/1] Ext4Pkg: Code correctness and security improvements
In my opinion, just "to prevent truncation".
This looks awkward, using an "EXT2" type in an "Ext4" function. Maybe just use UINT32?
The comment is misleading, because this is safe for EXT4 as
In my opinion, just "to prevent truncation".
This looks awkward, using an "EXT2" type in an "Ext4" function. Maybe just use UINT32?
The comment is misleading, because this is safe for EXT4 as
|
By
Marvin Häuser <mhaeuser@...>
·
#91666
·
|
|
Re: [edk2-platforms][PATCH v2 2/2] Ext4Pkg: Add base containing record macro for EXT4_FILE
Reviewed-by: Marvin Häuser <mhaeuser@...>
Reviewed-by: Marvin Häuser <mhaeuser@...>
|
By
Marvin Häuser <mhaeuser@...>
·
#91665
·
|
|
[edk2-platforms][PATCH v2 2/2] Ext4Pkg: Add base containing record macro for EXT4_FILE
We shouldn't use direct casts, because in the future it could break
the code, so using BASE_CR would be safe against possible structure
changes and rearrangements
Cc: Marvin Häuser
We shouldn't use direct casts, because in the future it could break
the code, so using BASE_CR would be safe against possible structure
changes and rearrangements
Cc: Marvin Häuser
|
By
Savva Mitrofanov
·
#91664
·
|
|
[edk2-platforms][PATCH v2 1/2] Ext4Pkg: Add symbolic links support
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
Provided support for symlink file type. Added routine which allows
reading and following them through recursive open() call. As a
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
Provided support for symlink file type. Added routine which allows
reading and following them through recursive open() call. As a
|
By
Savva Mitrofanov
·
#91663
·
|
|
[edk2-platforms][PATCH v2 0/2] Ext4Pkg: Add Symbolic Links support
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
Hi all,
In previous patchset I forgot to mention 3677 bug dedicated to symlinks.
So in v2 I took it into account.
This patchset adds symbolic
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677
Hi all,
In previous patchset I forgot to mention 3677 bug dedicated to symlinks.
So in v2 I took it into account.
This patchset adds symbolic
|
By
Savva Mitrofanov
·
#91662
·
|
|
[edk2-platforms][PATCH 2/2] Ext4Pkg: Add base containing record macro for EXT4_FILE
We shouldn't use direct casts, because in the future it could break
the code, so using BASE_CR would be safe against possible structure
changes and rearrangements
Cc: Marvin Häuser
We shouldn't use direct casts, because in the future it could break
the code, so using BASE_CR would be safe against possible structure
changes and rearrangements
Cc: Marvin Häuser
|
By
Savva Mitrofanov
·
#91661
·
|
|
[edk2-platforms][PATCH 1/2] Ext4Pkg: Add symbolic links support
Provided support for symlink file type. Added routine which allows
reading and following them through recursive open() call. As a security
meausure implemented simple symlink loop check with nest
Provided support for symlink file type. Added routine which allows
reading and following them through recursive open() call. As a security
meausure implemented simple symlink loop check with nest
|
By
Savva Mitrofanov
·
#91660
·
|
|
[edk2-platforms][PATCH 0/2] Ext4Pkg: Add Symbolic Links support
Hi all,
This patchset adds symbolic links support with simple recursion protection based
on symbolic link nest level limitation, also I included patch which adds BASE_CR
to extract EXT4_FILE private
Hi all,
This patchset adds symbolic links support with simple recursion protection based
on symbolic link nest level limitation, also I included patch which adds BASE_CR
to extract EXT4_FILE private
|
By
Savva Mitrofanov
·
#91659
·
|
|
[edk2-platforms][PATCH v2 1/1] Ext4Pkg: Code correctness and security improvements
This changes tends to improve security of code sections by fixing
integer overflows, missing aligment checks, unsafe casts, also
simplified some routines, fixed compiler warnings and corrected
This changes tends to improve security of code sections by fixing
integer overflows, missing aligment checks, unsafe casts, also
simplified some routines, fixed compiler warnings and corrected
|
By
Savva Mitrofanov
·
#91658
·
|
|
[edk2-platforms][PATCH v2 0/1] Ext4Pkg: Code correctness and security improvements
Hi all,
This is second version of patch in which I squashed commits into one.
Here attempts to improve security of code sections by fixing integer overflows,
missing aligment checks, unsafe casts.
Hi all,
This is second version of patch in which I squashed commits into one.
Here attempts to improve security of code sections by fixing integer overflows,
missing aligment checks, unsafe casts.
|
By
Savva Mitrofanov
·
#91657
·
|
|
[edk2-platforms][PATCH 10/10] Ext4Pkg: Group descriptor size must be 4-byte aligned
Adds 4-byte aligned check for superblock group descriptor size field
Cc: Marvin Häuser <mhaeuser@...>
Cc: Pedro Falcato <pedro.falcato@...>
Cc: Vitaly Cheptsov
Adds 4-byte aligned check for superblock group descriptor size field
Cc: Marvin Häuser <mhaeuser@...>
Cc: Pedro Falcato <pedro.falcato@...>
Cc: Vitaly Cheptsov
|
By
Savva Mitrofanov
·
#91656
·
|