REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3996 The DynamicPlatRepoLib has multiple reference to MemoryAllocationLib, such as DynamicPlatRepo.c and TokenMapper.c. Not including it in

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 Current DynamicTablesPkg

Add missing PCD for BSP FV Base/Size/Offsets. Cc: Nate DeSimone <nathaniel.l.desimone@...> Cc: Eric Dong <eric.dong@...> Cc: Liming Gao <gaoliming@...> Signed-off-by: Isaac

Hi Chasel, Please change the function signature for CallFspWrapperResetSystem() to take a EFI_STATUS as input. UINTN is certainly better than UINT32, but the actual data type defined in the FSP

Hi Pedro, Wow you are totally right... that is crazy! The exact opposite of the way 32-bit mode works! Good catch thank you! Please consider by code review feedback downgraded from a bug to a

After thinking about it some more, I suspect this is an issue in the debug library stack specific to BootScriptExecutorDxe. Being after exit-BS, it is in some ways a runtime driver. The

Series Reviewed-by: Isaac Oram <isaac.w.oram@...>

Tools, CI, Code base construction meeting series When: 07/18/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles Where: https://github.com/tianocore/edk2/discussions/2614 View

FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing on the build and this patch extended the support for 64bit build. Cc: Isaac Oram <isaac.w.oram@...> Cc: Nate DeSimone

FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing on the build and this patch extended the support for 64bit build. Cc: Isaac Oram <isaac.w.oram@...> Cc: Liming Gao

FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing on the build and this patch series extended the support for 64bit build. Cc: Isaac Oram <isaac.w.oram@...> Cc: Liming Gao

Hi Nate, Those whitespace and indents are for passing Uncrustify check. I notice Uncrustify was enabled in Edk2 merging check and one of my previous patch was failed due to spaces/indents were not

Hi Nate, This is not actually a problem, a 32-bit mov to a 32-bit register in long mode will zero the upper part. -- Pedro Falcato

Hi Chasel, Please see comments inline. Here is a summary of my feedback: #1) IntelFsp2Pkg/FspSecCore/X64/FspApiEntryI.nasm - line 34 - Bug: eax should be rax #2) IntelFsp2Pkg/Include/FspEas/FspApi.h

Reviewed-by: Guo Dong <guo.dong@...>

Pushed: https://github.com/tianocore/edk2/commit/586b4a1

Pushed: https://github.com/tianocore/edk2/commit/c966204

Hi all, I've been working on implementing S3 resume support for MinPlatform during the past few weeks. Presently, the last line of code that I know will execute on resume flows is

Reviewed-by: Michael D Kinney <michael.d.kinney@...>

Reviewed-by: Chasel Chiu <chasel.chiu@...> Thanks, Chasel