Hi Jon, Thank you for your feedback. Please see my response inline marked [SAMI]. Regards, Sami Mujawar [SAMI] I have followed the coding style as in rest of this file. My concern is that

Hi Liming, Thank you for your feedback. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 07/07/2022 02:51 am, gaoliming wrote:

Reviewed-by: Ray Ni <ray.ni@...>

Reviewed-by: Sheng Wei <w.sheng@...> The change matches the Vtd specification v 4.0

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974 CcProbeLib once was designed to probe the Confidential Computing guest type by checking the

From: Min M Xu <min.m.xu@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974 SecPeiCcProbeLib is designed to probe the Confidential Computing guest type in SEC/PEI phase. The CC guest

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3974 CcProbeLib once was designed to probe the Confidential Computing guest type by checking the PcdOvmfWorkArea. But this memory is allocated

Please break out the Flags attribute to its own structure so it better reflects the documentation in the spec. I am current using something like this, +^M +///^M +/// Node header definition shared

Hi, We are working on a feature that leverages UEFI HTTP protocol and during our testing we found an issue with the underlying DNS implementation. The current DNS implementation in EDK2 do not parse

Can we always enable CRYPTO_ENABLE? If yes, can we remove the macro?

Sami: I suggest to keep EFI_ACPI_IO_REMAPPING_TABLE_REVISION. Its value can be EFI_ACPI_IO_REMAPPING_TABLE_REV5, because the structure has been updated, such as EFI_ACPI_6_0_IO_REMAPPING_RC_NODE.

Reviewed-by: Liming Gao <gaoliming@...> Architecture set for the below recipient, distribution by

Mateusz: To be compatible, I suggest to add one new UefiDevicePathLibPeim.inf for PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf except for module type and base name. The

Thank you so much for the help, Jiewen! On 7/6/2022 6:09 PM, Yao, Jiewen wrote:

Merged https://github.com/tianocore/edk2/pull/3050

Hi Mike, How can sizeof(size_t) != sizeof(UINTN)? It seems to be quite a stretch to interpret the standard in a way that the native word size will not be able to store "the maximum size of a

Hi Pedro, This is an interesting feature. It is backwards compatible since you are adding a format specifier to the PrintLib class. There is a 2nd lib instance that needs to be updated, and that is

Hi Jiewen, Yes, the "https://github.com/kuqin12/edk2/tree/secure_boot_enhance_v3" is the branch I generate these patch series. And they have not been changed after sending

On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote: -#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0 +#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0 +#define EFI_ACPI_IO_REMAPPING_TABLE_REV5 0x5Based

Hi Sami, Yes, that would also be okay. Thanks.