Yes. I also prefer to have two patches.

Personally, you'd better to split this one patch to two, one is for MdePkg and another is for ShellPkg. Also cc MdePkg and ShellPkg maintainers. Thanks, Star

Personally, I think "eMMC" should be enough to instead " embedded Multi-Media Controller ". Others look good to me. And you'd better to get RB from ShellPkg's maintainer (Cced). Thanks, Star

This patch looks good to me. Reviewed-by: Yuwei Chen<yuwei.chen@...>

All (I tried to add potential key stakeholders in To list, but may miss someone): I am not sure how widely the EFI_PEI_VECTOR_HANDOFF_INFO_PPI is used today. This is an optional PPI that may be

With the updated commit message, Reviewed-by: Ray Ni <ray.ni@...>

Hi Sami, I am sure this is an issue for RAS case using Standalone MM. Please refer Omkar's comments for v1 (12/9/21, 1:46 AM): ----------------------------------------------------------------- Hi

Also, I noticed Scripts/Makefile defaults to RVCT. Are people still using that, or has everyone moved to gcc or the newer Arm compilers? -- Rebecca Cran On 4/10/22 19:16, Rebecca

With GNU Make 4.2.1, ifeq ($(EDK2_DSC),"") doesn't catch the case where EDK2_DSC isn't defined. So, switch to using ifndef. Signed-off-by: Rebecca Cran <rebecca@...> ---

The debugger in Arm Development Studio 2021.2 doesn't work with "ec = debugger.getExecutionContext(0)" because it's subsequently unable to access memory. Fix it by switching to "ec =

An error message in Scripts/Ds5/edk2_debugger.py was missing the word 'not'. Signed-off-by: Rebecca Cran <rebecca@...> --- ArmPlatformPkg/Scripts/Ds5/edk2_debugger.py | 2 +- 1 file changed, 1

I ran into some problems debugging EDK2 code using Development Studio with the files under ArmPlatformPkg/Scripts and these patches fix them. I'm using Arm Development Studio 2021.2 and not DS-5, so

Acked-by: Zhichao Gao <zhichao.gao@...> Thanks, Zhichao

This patch changed both MdeModulePkg and UefiPayloadPkg, had better split them into 2 patches? Thanks, Guo

Does the range (NvStorageBaseAddress, NvStorageLength) includes FTW spare range and FTW working range? If not, maybe rename them as (NvVariableBaseAddress, NvVariableLength) to make it clear. For

Reviewed-by: Guo Dong <guo.dong@...>

Reviewed-by: Guo Dong <guo.dong@...>

Reviewed-by: Guo Dong <guo.dong@...>

Reminder: TianoCore Design Meeting - APAC/NAMO When: 04/15/2022 9:30am to 10:30am (UTC+08:00) Asia/Shanghai Where: Microsoft Teams Organizer: Ray Ni ray.ni@... View

Hi Li, I had went through the whole patch set and gave feedbacks to the patch respectively. Apart from those comments, I have no problems with this contribution. I think we can adopt LoongArch port in