devel@edk2.groups.io

Re: [PATCH 1/1] UefiCpuPkg: Extend measurement of microcode patches to TPM

Thank you Ray for your kind and patient feedbacks and advices. I checked all 10 comments one by one and you could see my responses inline in below code change. I am testing new patch, will send to

By Yang, Longlong <longlong.yang@...> · #83403 ·

Re: [PATCH v1 07/14] DynamicTablesPkg: FdtHwInfoParser: Add GICC parser

Hi Pierre, Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar [SAMI] Is there a reason we are not supporting AFF3? [SAMI] Please adjust code alignment. [SAMI] Return directly from

By Sami Mujawar · #83402 ·

Re: [PATCH v1 06/14] DynamicTablesPkg: FdtHwInfoParser: Add Serial port parser

Hi Pierre, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 23/06/2021 01:38 PM, Pierre.Gondois@... wrote: [SAMI] I think this needs

By Sami Mujawar · #83401 ·

Re: [PATCH v1 03/14] DynamicTablesPkg: FdtHwInfoParser: Add FDT utility functions

Hi Pierre, I have a minor comment, otherwise this patch looks good to me. Regards, Sami Mujawar [SAMI] I think the comment here needs to be updated.

By Sami Mujawar · #83400 ·

Re: [PATCH v1 02/14] DynamicTablesPkg: FdtHwInfoParser: CM Object descriptor helper

Hi Pierre, Thank you for this patch. Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 23/06/2021 01:38 PM, Pierre.Gondois@... wrote:

By Sami Mujawar · #83399 ·

Re: [PATCH v4 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations

Hi Sami,

By Khasim Mohammed · #83398 ·

[PATCH v5 6/7] Platform/ARM/N1Sdp: Configuration Manager for N1Sdp

The dynamic tables framework utilizes the configuration manager protocol to get the platform specific information required for building the firmware tables. The configuration manager is a platform

By Khasim Mohammed · #83397 ·

[PATCH v5 7/7] Platform/ARM/N1Sdp: Enable ACPI tables and configuration manager

This patch enables ACPI tables and configuration manager for N1SDP Signed-off-by: Sami Mujawar <sami.mujawar@...> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@...> ---

By Khasim Mohammed · #83396 ·

[PATCH v5 5/7] Platform/ARM/N1Sdp: Introduce platform specific asl tables

This patch creates Dsdt.asl, SsdtPci.asl and SsdtRemotePci.asl files to provide the platform specific APCI table entries. Three PCI root ports are available on N1Sdp, PCI0 is the default root

By Khasim Mohammed · #83395 ·

[PATCH v5 2/7] Silicon/ARM/NeoverseN1Soc: Define new PCDs and configure memory map

This patch introduces new PCDs required to enable chip to chip interface and corresponding memory map is updated. Signed-off-by: Chandni Cherukuri <chandni.cherukuri@...> Signed-off-by: Khasim

By Khasim Mohammed · #83394 ·

[PATCH v5 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations

This patch adds PCDs and updates the fdf file for N1Sdp platform specific configurations. Signed-off-by: Deepak Pandey <Deepak.Pandey@...> Signed-off-by: Khasim Syed Mohammed

By Khasim Mohammed · #83393 ·

[PATCH v5 3/7] Platform/ARM/N1Sdp: Introduce platform DXE driver

Add an initial platform DXE driver and support for ramdisk devices. Signed-off-by: Deepak Pandey <Deepak.Pandey@...> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@...> ---

By Khasim Mohammed · #83392 ·

[PATCH v5 1/7] Silicon/ARM/NeoverseN1Soc: Fix missing function documentation

This patch adds missing documentation for few of the functions and fixes few formatting changes. Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@...> ---

By Khasim Mohammed · #83391 ·

Re: [PATCH v1 5/5] DynamicTablesPkg: Add DynamicPlatRepo library

Hi Pierre, Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 23/06/2021 02:36 PM, Pierre.Gondois@... wrote: [SAMI] I think the changes in

By Sami Mujawar · #83390 ·

Re: [PATCH v4 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations

Hi Sami,

By Khasim Mohammed · #83389 ·

Re: [PATCH v1 4/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenMapper

Hi Pierre, Please find my response inline marked [SAMI]. Regards, Sami Mujawar [SAMI] I think EFI_INVALID_PARAMETER or EFI_NOT_FOUND should be returned here. Can you check, please?

By Sami Mujawar · #83388 ·

Re: [PATCH v4 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations

Hi Khasim, Please find my response inline marked [SAMI]. Regards, Sami Mujawar [SAMI] Is the above disclaimer required? Is the "SPDX-License-Identifier: BSD-2-Clause-Patent" not sufficient? I

By Sami Mujawar · #83387 ·

[PATCH v1 1/1] MdePkg/Include: Smbios Specification 3.5.0 changes

Adds following changes 1) Added support for manufacturing mode in BIOS Characteristics Extension Byte 2. 2) Added support for slot height in System Slot Table (type 9). 3) Updated Built-in

By Abdul Lateef Attar · #83386 ·

[PATCH v1 0/1] MdePkg/Include SMBIOS 3.5.0 changes

Resubmitting the correct patch. Changes to include Smbios 3.5.0 specfication delta. Reference: https://github.com/abdattar/edk2/tree/smbios_3_5_0 Cc: Michael D Kinney

By Abdul Lateef Attar · #83385 ·

Re: [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

Fails to build for microvm. I guess this line is needed just next to Tcg2PhysicalPresenceLibNull line? (same problem on OvmfXen.dsc) take care, Gerd

By Gerd Hoffmann · #83384 ·

Messages