Hey Mike, Hey Andrew, I'll just reply to both mails at once :) Thanks! I'd keep STATIC actually just for the sake of not doing no-op changes that do not really do anything and for consistency with

This issue is independent of CONST. I’m not sure a coding style tool is smart enough to catch this generically? You need an understanding of C types to know if the local variable assignment is going

Hi Marvin, Some comments below. Mike

Hi Leif, Thanks for the feedback. Adjusting the EDK II C Coding Style should absolutely be part of this discussion. We need to work towards specific proposals. Here are the current open bugs

Thanks Mike, I will look into that. For others, I recently published an "uncrustify_poc_3" branch on my edk2 fork that demonstrates the latest set of results I've obtained with Uncrustify tool

Hi Michael, I am looking at your uncrustify_poc_3 branch, and I see an unexpected change related to use of IN/OUT in a function declaration. File: MdeModulePkg\Logo\Logo.c Before

Good day, +1, but while you're at it, can we have arguments not align to the function name... Status = Test ( a ); ... but to the next natural indentation level?

On the git-blame front we might be able to build a recipe that walks past the code style and line ending commits that would could add to an FAQ or Wiki. For bonus points we could add a git command

Reminder: TianoCore Community Meeting - EMEA / NAMO When: 10/07/2021 9:00am to 10:00am (UTC-07:00) America/Los

Reminder: TianoCore Community Meeting - EMEA / NAMO When: 10/07/2021 9:00am to 10:00am (UTC-07:00) America/Los

From: Pierre Gondois <Pierre.Gondois@...> In the GIC interrupt model, logical processors are required to have a Processor Device object in the DSDT and must convey each processor's GIC

From: Pierre Gondois <Pierre.Gondois@...> Introduce the CM_ARM_LPI_INFO CmObj in the ArmNameSpaceObjects. This allows to describe LPI state information, as described in ACPI 6.4, s8.4.4.3 "_LPI

From: Pierre Gondois <Pierre.Gondois@...> Add AmlAddLpiState() to generates AML code to add an _LPI state to an _LPI object created using AmlCreateLpiNode(). AmlAddLpiState increments the count

From: Pierre Gondois <Pierre.Gondois@...> _LPI object provides a method to describe Low Power Idle states that define the local power states for each node in a hierarchical processor

From: Pierre Gondois <Pierre.Gondois@...> Add AmlCodeGenMethodRetNameString() to generate AML code to create a Method returning a NameString (NS). AmlCodeGenMethodRetNameString ( "MET0",

From: Pierre Gondois <Pierre.Gondois@...> Add AmlCodeGenReturnNameString() to generate AML code for a Return object node, returning the object as a NameString. AmlCodeGenReturn ("NAM1",

From: Pierre Gondois <Pierre.Gondois@...> Add AmlCodeGenMethod() to generate code for a control method. AmlCodeGenMethod ("MET0", 1, TRUE, 3, ParentNode, NewObjectNode) is equivalent of the

From: Pierre Gondois <Pierre.Gondois@...> ASL provides a ResourceTemplate macro that creates a Buffer in which resource descriptor macros can be listed. The ResourceTemplate macro automatically

From: Pierre Gondois <Pierre.Gondois@...> Some AML object have a PkgLen which indicates the size of the AML object. The package length can be encoded in 1 to 4 bytes. The bytes used to encode the

From: Pierre Gondois <Pierre.Gondois@...> Add AmlCodeGenPackage() to generate AML code for declaring a Package() object. This function generates an empty package node. New elements can then be