Hi Gerd, After looking at the next patch, I wonder if it wouldn't be simpler to add/use VIRTIO_MMIO_DEVICE_VERSION_0_95 in a preliminary patch (2/5), returning EFI_UNSUPPORTED when not v0.95. Next

This looks like a bugfix in the previous patch... Going to revisit it.

virtio 1.0 has 64 feature bits instead of 32. Signed-off-by: Gerd Hoffmann <kraxel@...> --- .../VirtioMmioDeviceFunctions.c | 28 +++++++++++++++---- 1 file changed, 23

Add support for virtio 1.0 to the mmio transport. virtio 0.9.5 uses page size, page frame number and a fixed layout for the ring. virtio 1.0 uses the physical addresses for base address, used bits

Use QueueNumMax as QueueNum default for drivers which do not explicitly call VIRTIO_DEVICE_PROTOCOL->SetQueueSize(). Signed-off-by: Gerd Hoffmann <kraxel@...> ---

This little series adds virtio 1.0 support for the virtio-mmio transport. For the mmio transport the difference between 0.9.5 and 1.0 is rather small (when compared to the pci transport), it is just

Add defines for the config space offsets for virtio 1.0 mmio transport. Signed-off-by: Gerd Hoffmann <kraxel@...> Reviewed-by: Philippe Mathieu-Daude <philmd@...> ---

Hi, My expectation is that you would need either none (build without tdx support) or both (build with tdx support). If that is correct I don't see the point in splitting this into two libs. take

Thanks for reminder. I will use AsmCpuid in my next version. This is because TdxLib wrap the operations of TdCall and TdVmcall. While TdxProbeLib is a library to probe (call CPUID(0x21)) if it is td

Hi, Sorry, I'm a bit late to the party, but what is the overall long plan here? IIRC some of the TDX features require a separate firmware binary. So, if we need a separate binary anyway at some

Reviewed-by: Chasel Chiu <chasel.chiu@...>

I'm pretty sure it is preferred over duplicating code. Early setup code (before stack setup where you can't do calls) is a different story. Also: Why there are separate TdxProbeLib + TdxLib

From: "Loo, Tung Lun" <tung.lun.loo@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3567 This patch is to enable config editor to have a new feature that can spell out the delta

Commit 2f0188b56ef4 ("Revert "Platform/RaspberryPi: Setup option for...") mistakenly introduced to files which are residues from a conflict resolution. Fix that. Signed-off-by: Grzegorz Bernacki

I could probably write a patch, but OVMF does not use this SecCore (and still something is misaligned :) ), and I don't have any other platform. Maybe I can ask Bret to test it as part of some PE

Hi, Please do not merge this patch. Unfortunately, I added a few more unnecessary files under Commit 2f0188b56ef4. I will send the new version of the patch soon. thanks, greg pt., 13 sie 2021 o

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3566 Following PI spec: when there has Ffs with EFI_FFS_FILE_HEADER2, the Parent Fv of the Ffs need set to FileSystemGuid3; when all the Ffs with

Hi Ray, This same header will be commonly used for both MM communicate PPI and Protocol. If including this definition in MmCommunicate protocol header, the potential PEIM that installs MM communicate

Can you kindly explain why you choose to define the definitions in PiMultiPhase.h instead of MmCommunication.h? Thanks, Ray

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 This change added support of installing