|
Re: [PATCH] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates
By
Wu, Hao A
·
#78927
·
|
|
Re: [PATCH] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates
Good day Hao,
Sorry for the confusion, and you are (rightfully!) not alone. :( I'll quote myself from a different patch:
[...] for some reason, none of the other patch series had indices
Good day Hao,
Sorry for the confusion, and you are (rightfully!) not alone. :( I'll quote myself from a different patch:
[...] for some reason, none of the other patch series had indices
|
By
Marvin Häuser <mhaeuser@...>
·
#78926
·
|
|
Re: [PATCH] MdeModulePkg/DxeCore: Consistent DebugImageInfoTable updates
Sorry Marvin Häuser,
Could you help to confirm that below 9 MdeModulePkg related patches are either:
* All independent patches
* Belong to a patch series that includes all these 9 MdeModulePkg
Sorry Marvin Häuser,
Could you help to confirm that below 9 MdeModulePkg related patches are either:
* All independent patches
* Belong to a patch series that includes all these 9 MdeModulePkg
|
By
Wu, Hao A
·
#78925
·
|
|
[PATCH v2 1/1] MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands
The legacy codebase allowed SMM images to be registered for profiling
from DXE. Support for this has been dropped entirely, so remove the
remaining handlers.
Cc: Hao A Wu <hao.a.wu@...>
Cc:
The legacy codebase allowed SMM images to be registered for profiling
from DXE. Support for this has been dropped entirely, so remove the
remaining handlers.
Cc: Hao A Wu <hao.a.wu@...>
Cc:
|
By
Marvin Häuser <mhaeuser@...>
·
#78924
·
|
|
[PATCH] UefiPayloadPkg: Fix the non-ascii character in UniversalPayloadEntry.c
Fix the non-ascii character in UniversalPayloadEntry.c
Cc: Ray Ni <ray.ni@...>
Cc: Maurice Ma <maurice.ma@...>
Cc: Benjamin You <benjamin.you@...>
Signed-off-by: DunTan
Fix the non-ascii character in UniversalPayloadEntry.c
Cc: Ray Ni <ray.ni@...>
Cc: Maurice Ma <maurice.ma@...>
Cc: Benjamin You <benjamin.you@...>
Signed-off-by: DunTan
|
By
duntan
·
#78923
·
|
|
Re: [PATCH 1/1] MdeModulePkg/Console: Improve encoding of box drawing characters
Sorry Zhichao and Ray, could you please help to check if you have comments for this patch. Thanks in advance.
Hello Caden Kline, could you help to provide the information on what kind of unit test
Sorry Zhichao and Ray, could you please help to check if you have comments for this patch. Thanks in advance.
Hello Caden Kline, could you help to provide the information on what kind of unit test
|
By
Wu, Hao A
·
#78922
·
|
|
Re: [PATCH] UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption
Hey Ray,
clang-tidy gave me a hand. :)
"Suspicious usage of 'sizeof(K)'; did you mean 'K'?
clang-tidy(bugprone-sizeof-expression)"
I set it up as follows (this is *not* sophisticated, just added
Hey Ray,
clang-tidy gave me a hand. :)
"Suspicious usage of 'sizeof(K)'; did you mean 'K'?
clang-tidy(bugprone-sizeof-expression)"
I set it up as follows (this is *not* sophisticated, just added
|
By
Marvin Häuser <mhaeuser@...>
·
#78921
·
|
|
Re: [PATCH] MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands
Hey Jiewen,
Good point, sure. Will probably add ASSERTs as well, if that is fine with you.
Best regards,
Marvin
Hey Jiewen,
Good point, sure. Will probably add ASSERTs as well, if that is fine with you.
Best regards,
Marvin
|
By
Marvin Häuser <mhaeuser@...>
·
#78920
·
|
|
Re: [PATCH] SecurityPkg/DxeImageVerificationLib: Always lookup SHA-256 hash in dbx
Hey Jiewen,
Right, I meant to ask about this and forgot (sorry, I sent out a bit less than 30 patches yesterday :) ).
Why do we record and potentially defer the loading of images that are distrusted
Hey Jiewen,
Right, I meant to ask about this and forgot (sorry, I sent out a bit less than 30 patches yesterday :) ).
Why do we record and potentially defer the loading of images that are distrusted
|
By
Marvin Häuser <mhaeuser@...>
·
#78919
·
|
|
Re: [PATCH] MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands
Can we define 3 and 4 to be "reserved and do not use", instead of removed ?
-#define SMRAM_PROFILE_COMMAND_REGISTER_IMAGE 0x3
-#define SMRAM_PROFILE_COMMAND_UNREGISTER_IMAGE
Can we define 3 and 4 to be "reserved and do not use", instead of removed ?
-#define SMRAM_PROFILE_COMMAND_REGISTER_IMAGE 0x3
-#define SMRAM_PROFILE_COMMAND_UNREGISTER_IMAGE
|
By
Yao, Jiewen
·
#78918
·
|
|
Re: [PATCH] SecurityPkg/DxeImageVerificationLib: Always lookup SHA-256 hash in dbx
Good day,
I just woke up to this mess, yes. I actually did follow that guide, just around 3 years ago I believe, so let me check where things went wrong since then...
The patch you quoted was a
Good day,
I just woke up to this mess, yes. I actually did follow that guide, just around 3 years ago I believe, so let me check where things went wrong since then...
The patch you quoted was a
|
By
Marvin Häuser <mhaeuser@...>
·
#78917
·
|
|
Re: [PATCH] MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands
Reviewed-by: Ray Ni <ray.ni@...>
+Star and Jiewen for confirmation.
Reviewed-by: Ray Ni <ray.ni@...>
+Star and Jiewen for confirmation.
|
By
Ni, Ray
·
#78916
·
|
|
Re: [PATCH] UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption
It's so lucky that no code calls AllocatePool so the bug didn't cause real issues. (I tried to remove AllocatePool() and build still passed.)
Thanks for catching the bug. Reviewed-by: Ray Ni
It's so lucky that no code calls AllocatePool so the bug didn't cause real issues. (I tried to remove AllocatePool() and build still passed.)
Thanks for catching the bug. Reviewed-by: Ray Ni
|
By
Ni, Ray
·
#78915
·
|
|
Re: [PATCH] SecurityPkg/DxeImageVerificationLib: Always lookup SHA-256 hash in dbx
Hi Marvin
With this patch, the path "Action == EFI_IMAGE_EXECUTION_AUTH_SIG_FOUND" no longer exists.
Do you think we should remove EFI_IMAGE_EXECUTION_AUTH_SIG_FOUND as well?
Thank you
Yao
Hi Marvin
With this patch, the path "Action == EFI_IMAGE_EXECUTION_AUTH_SIG_FOUND" no longer exists.
Do you think we should remove EFI_IMAGE_EXECUTION_AUTH_SIG_FOUND as well?
Thank you
Yao
|
By
Yao, Jiewen
·
#78914
·
|
|
[PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused 100ms delay
https://bugzilla.tianocore.org/show_bug.cgi?id=3D3525
After PciSegmentLib using Dynamic PCD for Pcie base address such
long delay found in FSP. The root cause is some of the PCD service
PPIs not
https://bugzilla.tianocore.org/show_bug.cgi?id=3D3525
After PciSegmentLib using Dynamic PCD for Pcie base address such
long delay found in FSP. The root cause is some of the PCD service
PPIs not
|
By
GregX Yeh
·
#78913
·
|
|
Re: [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion.
Would you please tell us how many TPM2 chip you have tested?
I think we need consider the compatibility of exiting TPM2 chips, to make sure the code still work.
Thank you
Yao Jiewen
Would you please tell us how many TPM2 chip you have tested?
I think we need consider the compatibility of exiting TPM2 chips, to make sure the code still work.
Thank you
Yao Jiewen
|
By
Yao, Jiewen
·
#78912
·
|
|
Re: [PATCH] SecurityPkg: Debug code to audit BIOS TPM extend operations.
Some feedback:
1) I think it is OK to add Tpm2PcrReadForActiveBank() API.
But I feel we will add too many noise to dump Tpm2PcrReadForActiveBank() in the code everytime.
I am not sure why it is
Some feedback:
1) I think it is OK to add Tpm2PcrReadForActiveBank() API.
But I feel we will add too many noise to dump Tpm2PcrReadForActiveBank() in the code everytime.
I am not sure why it is
|
By
Yao, Jiewen
·
#78911
·
|
|
Re: [PATCH] Reallocate TPM Active PCRs based on platform support.
Hi Rodrigo
I don't understand the problem statement.
This code has been there for long time. What is changed recently ?
Thank you
Yao Jiewen
Hi Rodrigo
I don't understand the problem statement.
This code has been there for long time. What is changed recently ?
Thank you
Yao Jiewen
|
By
Yao, Jiewen
·
#78910
·
|
|
Re: [PATCH] SecurityPkg/DxeImageVerificationLib: Always lookup SHA-256 hash in dbx
It seems there are 3 patches sent from Marvin Häuser and I suppose they're in one patch-set, right? Please follow the link below to send out patch-set for
It seems there are 3 patches sent from Marvin Häuser and I suppose they're in one patch-set, right? Please follow the link below to send out patch-set for
|
By
Min Xu
·
#78909
·
|
|
[PATCH 2/3] efi_gdb.py: - Add gdb EFI commands and pretty Print
https://bugzilla.tianocore.org/show_bug.cgi?id=3500
Use efi_debugging.py Python Classes to implement EFI gdb commands:
(gdb) help efi
Commands for debugging EFI. efi <cmd>
List of efi
https://bugzilla.tianocore.org/show_bug.cgi?id=3500
Use efi_debugging.py Python Classes to implement EFI gdb commands:
(gdb) help efi
Commands for debugging EFI. efi <cmd>
List of efi
|
By
Andrew Fish
·
#78908
·
|