From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3520 TestPointSmmEndOfDxeSmrrFunctional() uses the incorrect byte index to skip the test.

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3518 Per the protocol definition, the caller must allocate the input structure and set the

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3531 The MessageLength field of EFI_MM_COMMUNICATE_HEADER as defined

From: Michael Kubacki

Thanks for your update. Reviewed-by: Liming Gao <gaoliming@...> If no other comments, I will merge this patch set for 202108 stable tag. Thanks Liming

Hi Michael, I have not tried actually. Now that TiogaPass has been merged upstream we have not been focusing on Mt. Olympus. I believe the original code was pair programmed by Mallik and Jiewen and

Caden, Please make sure you test this patch thoroughly. With that... Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...> Thanks! Nate

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Hi Michael, Comments are inline. Thanks, Nate

Hi Michael, Comments are inline. Thanks, Nate

Hi Michael, Here is a summary of my feedback: 1. Patch 2/5: DxeCheckTcgTrustedBoot.c: line 44 - I think we should also have a ZeroMem ((VOID *) &ProtocolCapability, sizeof (ProtocolCapability))

Hi Mike, Thanks for the helpful pointers. I'll consider everything for V2, which I'll submit as soon as possible (hopefully tomorrow). RE: Code style. I'll re-run ECC and try to solve the issues.

Hi Dandan, Thanks for letting me know. I added Bret and Sean to the thread for broader view in our scope. But currently our StandaloneMm Core does not report performance data to

Hi Tung Lun, Is this patch still needed or was it superseded by https://edk2.groups.io/g/devel/message/75168 ? Thanks, Nate

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 While build the initial page table, the SetCr3ForPageTables64 checks whether SEV-ES is enabled. If so, clear the page encryption mask from

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Update the SEV support to switch to using the newer work area format. Cc: Min Xu <min.m.xu@...> Cc: Tom Lendacky

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Both the TDX and SEV support needs to reserve a page in MEMFD as a work area. The page will contain meta data specific to the guest

Based on the discussion on the mailing list, we agreed that instead of wasting extra page in the MEMFD, we can reuse the SevEsWorkArea buffer for the TDX. To avoid any confusion, lets introduce a