Hi Min, This is wrong, we need to check the SevEs sub type and not the global Sev enable. This also need to be broken into at least two commits 1. introduce the updated CcWorkArea structure 2.

Mike, do the comments in this patch work for you? Would be nice to get this in prior to the 8/9 freeze if possible. Thanks, Jeff

Hi, Please find my response inline. Regards, Sayanta

Pushed as 3ccc21d918c..2f0188b56ef4 Thanks to Grzegorz and others involved for finding a way to address this boot protocol issue elegantly! -- Ard.

Yeah, go for the patch. - Bret

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@...>

Hi Omkar, How did you check that the HEST table is populated correctly? There is no HEST parser in Acpiview at the moment. Do you plan to add an HEST parser to Acpiview? Regards, Sami Mujawar

Yes. The unmeasured here means the contents of the page is not measured but the PAGE_INFO is measured for all the pages added before the VM launch. The page info of both the secrets and cpuid page

Hi Omkar, Thank you for this patch. I have a minor suggestion marked inline as [SAMI], other than that this patch looks good to me. Reviewed-by: Sami Mujawar<sami.mujawar@...> Regards, Sami

Yes, patches were missing because the mailing list chose to unsort and retain non-consecutive patches (they were sent in order) after they exceeded the autoresponder mail loop guard of 40

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates usage of gPchSpiPpiGuid to use the new interface that identifies SPI flash

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 The library instance has moved to IntelSiliconPkg. Cc: Nate DeSimone

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates TigerlakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in

Thank you Jiewen for your feedback. I will try to address the comments in next version. I don't know why we choose "Ovmf" from the LaunchSecretsBase PCD. I thought PCD's specific the Uefi typically

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Adds a Traditional MM and Standalone MM SPI FVB Service driver to IntelSiliconPkg.

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 SpiFlashCommonLib is duplicated in multiple places across the MinPlatform design in

Hi Omkar, Please find my response inline marked [SAMI]. Regards, Sami Mujawar [SAMI] Should this patch be split into 2? [SAMI] I feel there can be a simple way to

Hi Omkar, Please find my response below marked [SAMI] Regards, Sami Mujawar [SAMI] Not sure if a trailing underscore would be right to use for the name tag. Can