Can this be done in OvmfPkg/AmdSevDxe/AmdSevDxe.c or is that too early?
BIT17
What's the reason for the loop? I would think that just checking
0x40000000 would be enough, so a comment seems to be
Can this be done in OvmfPkg/AmdSevDxe/AmdSevDxe.c or is that too early?
BIT17
What's the reason for the loop? I would think that just checking
0x40000000 would be enough, so a comment seems to be
+ gUniversalPayloadBootManagerMenuFileGuid
Had better rename this guid to remove "UniversalPayload" from the name since this guid is not defined in universal payload specification.
Thanks,
Guo
+ gUniversalPayloadBootManagerMenuFileGuid
Had better rename this guid to remove "UniversalPayload" from the name since this guid is not defined in universal payload specification.
Thanks,
Guo
Maybe add a comment here that the "Mode" doesn't care whether the change
was for 4k vs 2mb vs 1gb. It is just tracking the total number of pages
changed (should you just remove those #defines for the
Maybe add a comment here that the "Mode" doesn't care whether the change
was for 4k vs 2mb vs 1gb. It is just tracking the total number of pages
changed (should you just remove those #defines for the
Could you change this MACRO definition as below to specifically disable EMU variable?
DEFINE EMU_VARIABLE_ENABLE = FALSE
This way, late we could enable other variable drivers (e.g. SMM
Could you change this MACRO definition as below to specifically disable EMU variable?
DEFINE EMU_VARIABLE_ENABLE = FALSE
This way, late we could enable other variable drivers (e.g. SMM
Please update the below function description to match the function impl.
+/**
+ Find DXE core from FV and build DXE core HOBs.
+
+ @param[in] FvBase FV base to load DXE core
Please update the below function description to match the function impl.
+/**
+ Find DXE core from FV and build DXE core HOBs.
+
+ @param[in] FvBase FV base to load DXE core
Could you add description why you need add new library DxeHobLib + DxeHobListLib for DXE drivers instead of using MdePkg/Library/DxeHobLib/DxeHobLib.inf?
And please check if UefiLib is still required
Could you add description why you need add new library DxeHobLib + DxeHobListLib for DXE drivers instead of using MdePkg/Library/DxeHobLib/DxeHobLib.inf?
And please check if UefiLib is still required
Does this have to be a new library? It's just a single function and so I
would think it could live in the BaseMemEncryptSevLib library where the
change to the c-bit is being done anyway.
Use the BIT0
Does this have to be a new library? It's just a single function and so I
would think it could live in the BaseMemEncryptSevLib library where the
change to the c-bit is being done anyway.
Use the BIT0
Remove this new line.
Typically we should invoke the HC as soon as the page state is changed in the PTE.
Why we are notifying it too late? Is this because you are trying to avoid asm code
or there is
Remove this new line.
Typically we should invoke the HC as soon as the page state is changed in the PTE.
Why we are notifying it too late? Is this because you are trying to avoid asm code
or there is
I see that in patch#4 you are adding a support to query the HV features flag
to determine whether HV supports the Live migration. You probably need to
pull that function into this library and and
I see that in patch#4 you are adding a support to query the HV features flag
to determine whether HV supports the Live migration. You probably need to
pull that function into this library and and
Remove this newline.
^^^^
2021
Looking at the function signature it seems this routine is used for both set
and clear. Please update the comment accordingly.
Remove this newline.
^^^^
2021
Looking at the function signature it seems this routine is used for both set
and clear. Please update the comment accordingly.
