Thank you, Michael. Acked-by: Jiewen Yao <Jiewen.yao@...>

One final comment, PurleyOpenBoardPkg/Override/edk2/MdeModulePkg/Bus/Pci/PciBusDxe seems a little excessive, I think you can do PurleyOpenBoardPkg/Override/MdeModulePkg/Bus/Pci/PciBusDxe and everyone

Could you provide more info on the issues in fixed by this patch? There is a UEFI payload patch (under code review) to support the bootloader to provide a HOB on the PCI resources, this way the UEFI

Also, uefi_2500_800.efi should not be added directly inside of PurleyOpenBoardPkg. You will need to move that to edk2-non-osi. I'm not sure exactly which driver that is, but I have a suspicion that it

Hi Manic, I looked over all of your changes. The code itself looks good. However, there is an issue with the copyright headers that you have placed on the top of many of the files included here. It

It's been a week and I haven't seen any feedback. Please review when possible. Thanks, Michael

Hi Hao, Sorry that I missed comments for this patch earlier. You are correct. I only inspected SmmLockBoxPeiLib. The PEI instance handled mode switch with ```OFFSET_OF ``` function. But DXE instance

"dbt" and "dbx" are swapped in the comments? Look for groups of 3 underscores ("___") below... + ## GUID used to specify section with default ___dbt___ content + gDefault___dbx___FileGuid = {

cmd_load_symbols.py can only load symbols from a firmware volume. Add the possibility to use UEFI console output to calculate dll load address and send add-symbol-file commands directly to ArmDS

cmd_load_symbols.py can only load symbols from FV. Add the possibility to use UEFI console output to calculate dll load address and send add-symbol-file commands directly to ArmDS debugger dll load

Hey Ray, Sure, thanks a lot for taking the time. I will need a bit longer to get to it, sorry. :) Best regards, Marvin

Thanks for the review. Updated patch has been sent here: https://edk2.groups.io/g/devel/message/76553. Please let me know if any other feedbacks. Regards, Kun

From: Sean Brogan <sean.brogan@...> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 On Linux the shell expands the wildcard paths and causes multiple files to be missed. This

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/76427 v2 patch change includes feedback for

Thanks Leif for the info. The issue happened since below change  037d86dd7a (20/06/06 14:49) ArmPkg/PlatformBootManagerLib: don't connect all devices on each boot <Ard Biesheuvel> From that commit,

Thanks Leif for catching that. Will replace it by DebugPrint in the v3. Best regards, Nhi

Because the cache-related functions/definitions in the AmpereCpuLib will be replaced by ArmLib so I'm going to replace the SmbiosCpuDxe by

Hi Leif, Thanks for reviewing. Will address all your comments from this patch. Best regards, Nhi

Thanks for catching that. Will correct them in the v3. Best regards, Nhi

Thanks, Leif. I will use a PCD instead of build option flag like above and will update the commit message to explain how it works. Best regards, Nhi