devel@edk2.groups.io

Re: [PATCH 6/6] NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro

Reviewed-by: Maciej Rabeda <maciej.rabeda@...>

By Maciej Rabeda · #76391 ·

Re: [PATCH 5/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

Reviewed-by: Maciej Rabeda <maciej.rabeda@...>

By Maciej Rabeda · #76390 ·

Re: [PATCH 4/6] NetworkPkg/IScsiDxe: support multiple hash algorithms for CHAP

Laszlo, Comments inline. Any chance to define an enum type for Algorithm? IMHO it brings more meaning to that number and limits the set of values it is expected to have. Either break like regular

By Maciej Rabeda · #76389 ·

Re: [PUBLIC edk2 PATCH v2 01/10] NetworkPkg/IScsiDxe: wrap IScsiCHAP source files to 80 characters

I second Ray on the question! I can only assume it is vi without syntax coloring... :)

By Maciej Rabeda · #76388 ·

Re: [PATCH 3/6] NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest sizes

To cut to the chase on this patch: Reviewed-by: Maciej Rabeda <maciej.rabeda@...>

By Maciej Rabeda · #76387 ·

Re: [PUBLIC edk2 PATCH v2 01/10] NetworkPkg/IScsiDxe: wrap IScsiCHAP source files to 80 characters

No objection on the patch. Just curious what editor you are using😊

By Ni, Ray · #76386 ·

Re: [PATCH 2/6] NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files

Nicely aligned spacing... Reviewed-by: Maciej Rabeda <maciej.rabeda@...> On 08-Jun-21 15:06, Laszlo Ersek wrote:

By Maciej Rabeda · #76385 ·

Re: [PATCH 1/6] NetworkPkg/IScsiDxe: re-set session-level authentication state before login

Reviewed-by: Maciej Rabeda <maciej.rabeda@...>

By Maciej Rabeda · #76384 ·

[edk2-platforms][PATCH v2 5/5] Platform/Sgi: Cleanup build options for StandaloneMM context

From: Omkar Anand Kulkarni <omkar.kulkarni@...> The Arm reference design platforms support only AArch64 mode for StandaloneMM execution context. So cleanup the existing build options specified

By Pranav Madhu · #76383 ·

[edk2-platforms][PATCH v2 4/5] Platform/Sgi: update _OSC control method to control LPI and CPPC

Define and use the global macro LPI_EN and CPPC_EN to enable low power idle and CPPC support for reference design platforms. Update platform wide _OSC control method to enable/disable low power idle

By Pranav Madhu · #76382 ·

[edk2-platforms][PATCH v2 3/5] Platform/Sgi: define the macro ENABLE_GOP

From: Thomas Abraham <thomas.abraham@...> Define and use the global macro ENABLE_GOP to enable the use of the Graphics Output Protocol (GOP). Enabling this macro allows GOP protocol to be used

By Pranav Madhu · #76381 ·

[edk2-platforms][PATCH v2 2/5] Platform/Sgi: Add GED support

Add ACPI Generic Event Device (GED) support for Arm's reference design platforms. The SP804 dual-timer interrupt is used as the event source for GED. Signed-off-by: Pranav Madhu

By Pranav Madhu · #76380 ·

[edk2-platforms][PATCH v2 1/5] Platform/Sgi: Enable PrimeCell GPIO

The HW-Reduced ACPI model has specific requirements for GPIO controllers. Arm's reference design Platforms has PrimeCell GPIO (PL061) integrated in the RoS subsystem to provide GPIO support. Add GPIO

By Pranav Madhu · #76379 ·

[edk2-platforms][PATCH v2 0/5] Platform/Sgi: Miscellaneous updates

Changes since V1: - Rebase the patches on top of latest master branch This patch series introduces few miscellaneous updates for Arm's Reference Design platforms. The first two patches add a

By Pranav Madhu · #76378 ·

Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

Acked-by: Heinrich Schuchardt <xypron.glpk@...>

By Heinrich Schuchardt · #76377 ·

Re: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

Thanks for catching this, Heinrich. I sent v2 to also revert TPL_HIGH_LEVEL changes in ae7e5477b555. Best Regards, Sunny Wang

By Sunny Wang · #76376 ·

[edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent failures. Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for exclusive use by the firmware. The creation of events

By Sunny Wang · #76375 ·

Re: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

Please, have a look at commit ae7e5477b555 ("uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx") too. Acked-by: Heinrich Schuchardt <xypron.glpk@...>

By Heinrich Schuchardt · #76374 ·

Re: [PATCH v1 2/5] MdeModulePkg: PiSmmIpl: Update MessageLength calculation for MmCommunicate

A couple of minor comments below:

By Wu, Hao A · #76373 ·

Re: [PATCH v1 4/5] MdeModulePkg: SmiHandlerProfileInfo: Updated MessageLength calculation

By Wu, Hao A · #76372 ·

Messages