devel@edk2.groups.io

Re: [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

Yes, I will try that approach. At least I have been asked by it in the kernel ML folks to avoid using the moving URL. So, I am doing similar thing for OVMF commit messages. Yes, it simply

By Brijesh Singh · #76232 ·

Re: [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

Well I'm sure I'm day-dreaming, but here's what I'd like, all at the same time of course: - to-the-point PCD names and explanations in the DEC file, - minimize the new pages carved out of MEMFD, -

By Laszlo Ersek · #76231 ·

Re: [PATCH RFC v3 03/22] OvmfPkg/MemEncryptSevLib: extend the workarea to include SNP enabled field

Thanks. I agree there are conflicting goals here (and by that I don't mean my goals conflict with yours). One goal is to avoid speculative generality, as (in my experience) actual usage of such

By Laszlo Ersek · #76230 ·

Re: [Patch V3 1/9] MdeModulePkg: Add Universal Payload general defination header file

I see use of the abbreviation PLD in this series. PLD is sometimes interpreted as Programmable Logic Device. Given this is for Universal Payload, I recommend using UNIVERSAL_PAYLOAD or PAYLOAD as

By Michael D Kinney · #76229 ·

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

It looks like I'll be travelling that day, but should be able to attend at least the first 45 minutes of the design review from the airport lounge. On TdMailbox and TdHob, we already have two SEV

By James Bottomley · #76228 ·

Re: [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

Awesome, thank you! Laszlo

By Laszlo Ersek · #76227 ·

Re: [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

Hmm, no; you have convinced me. Please go ahead with FileHandleLib. Thank you for taking the time to talk this through with me. I prefer option (a), with the extension that we need to update

By Laszlo Ersek · #76226 ·

Re: [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

Yes, it should be an opaque to the guest firmware. If someone wants to do attestation inside the OVMF then they may need to know the whether its an SEV or SEV-SNP guest. If its SEV guest then blob

By Brijesh Singh · #76225 ·

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

No, that's not the case; PlatformFvbLibNull only turns the hooks (special callbacks) into no-ops; the normal operation of EmuVariableFvbRuntimeDxe is not disrupted. The APIs in the PlatformFvbLib

By Laszlo Ersek · #76224 ·

Re: [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

I have to debug it, but it did appear that this circular dependency caused problem for the SEV guest when SMM is enabled. If SMM is enabled, then I get a random #UD as soon as I link the VmgExit

By Brijesh Singh · #76223 ·

[Patch] StandaloneMmPkg: Fixed communicating from TF-A failed issue

TF-A: TrustedFirmware-a SPM: Secure Partition Manager(MM) For AArch64, when SPM enable in TF-A, TF-A may communicate to MM with buffer address (PLAT_SPM_BUF_BASE). The address is different from

By Ming Huang · #76222 ·

[PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h

Many of the cache definitions in ArmLibPrivate.h are being used outside of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make them public, and remove the include of ArmLibPrivate.h from

By Rebecca Cran <rebecca@...> · #76221 ·

Re: [PATCH RFC v3 03/22] OvmfPkg/MemEncryptSevLib: extend the workarea to include SNP enabled field

One reason I can think of is if we ever decided validate the pages before the SevEsProtocolCheck(). The version 2 of GHCB spec adds few new NAE's that are SNP specific such as Page State Change. They

By Brijesh Singh · #76220 ·

[PATCH 6/6] NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro

Introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro for NetworkPkg. When explicitly set to FALSE, remove MD5 from IScsiDxe's CHAP algorithm list. Set NETWORK_ISCSI_MD5_ENABLE to TRUE by

By Laszlo Ersek · #76219 ·

[PATCH 5/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

Insert a SHA256 CHAP_HASH structure at the start of "mChapHash". Update ISCSI_CHAP_MAX_DIGEST_SIZE to SHA256_DIGEST_SIZE (32). This enables the initiator and the target to negotiate SHA256 for CHAP,

By Laszlo Ersek · #76218 ·

[PATCH 4/6] NetworkPkg/IScsiDxe: support multiple hash algorithms for CHAP

Introduce the "mChapHash" table, containing the hash algorithms supported for CHAP. Hash algos listed at the beginning of the table are preferred by the initiator. In ISCSI_CHAP_STEP_ONE, send such a

By Laszlo Ersek · #76217 ·

[PATCH 3/6] NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest sizes

IScsiDxe uses the ISCSI_CHAP_RSP_LEN macro for expressing the size of the digest (16) that it solely supports at this point (MD5). ISCSI_CHAP_RSP_LEN is used for both (a) *allocating*

By Laszlo Ersek · #76216 ·

[PATCH 2/6] NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files

In the next patches, we'll need more room for various macro and parameter names. For maintaining the current visual alignments, insert some horizontal whitespace in preparation. "git show -b" produces

By Laszlo Ersek · #76215 ·

[PATCH 1/6] NetworkPkg/IScsiDxe: re-set session-level authentication state before login

RFC 7143 explains that a single iSCSI session may use multiple TCP connections. The first connection established is called the leading connection. The login performed on the leading connection is

By Laszlo Ersek · #76214 ·

[PATCH 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355 Repo: https://pagure.io/lersek/edk2.git Branch: iscsi_sha256_bz3355 Please find the Feature Request described in comment#0 of the

By Laszlo Ersek · #76213 ·

Messages