devel@edk2.groups.io

[PATCH 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355 Repo: https://pagure.io/lersek/edk2.git Branch: iscsi_sha256_bz3355 Please find the Feature Request described in comment#0 of the

By Laszlo Ersek · #76213 ·

Re: [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

The legacy x86 loader should only be kept if there is a strong need to do so. Keeping it around for some theoretical compatibility concern is simply not worth it, IMHO. Having two boot paths to

By Ard Biesheuvel · #76212 ·

Re: [PATCH edk2-test 1/1] uefi-sct/SctPkg: IHV: type mismatch in Simple Network test

This patch is upstreamed by the commit-id: https://github.com/tianocore/edk2-test/commit/b68e40293485ce3c6bf50294900d068bbaeba213

By G Edhaya Chandran · #76211 ·

Re: [PATCH edk2-test 1/1] uefi-sct/SctPkg: IHV: type mismatch in Simple Network test

Reviewed-by: G Edhaya Chandran<edhaya.chandran@...>

By G Edhaya Chandran · #76210 ·

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

Right, pflash is not part of the *board* in any TDX setup. This is a limitation from the Qemu (the tdx-qemu) side. TDVF is copied into RAM. Generic loader is the one for it. In this case (pflash is

By Min Xu · #76209 ·

[PUBLIC edk2 PATCH v2 10/10] NetworkPkg/IScsiDxe: check IScsiHexToBin() return values

IScsiDxe (that is, the initiator) receives two hex-encoded strings from the iSCSI target: - CHAP_C, where the target challenges the initiator, - CHAP_R, where the target answers the challenge from

By Laszlo Ersek · #76208 ·

[PUBLIC edk2 PATCH v2 09/10] NetworkPkg/IScsiDxe: fix IScsiHexToBin() buffer overflow

The IScsiHexToBin() function documents the EFI_BUFFER_TOO_SMALL return condition, but never actually checks whether the decoded buffer fits into the caller-provided room (i.e., the input value of

By Laszlo Ersek · #76207 ·

[PUBLIC edk2 PATCH v2 08/10] NetworkPkg/IScsiDxe: fix IScsiHexToBin() hex parsing

The IScsiHexToBin() function has the following parser issues: (1) If the *subject sequence* in "HexStr" is empty, the function returns EFI_SUCCESS (with "BinLength" set to 0 on output). Such

By Laszlo Ersek · #76206 ·

[PUBLIC edk2 PATCH v2 06/10] NetworkPkg/IScsiDxe: assert that IScsiBinToHex() always succeeds

IScsiBinToHex() is called for encoding: - the answer to the target's challenge; that is, CHAP_R; - the challenge for the target, in case mutual authentication is enabled; that is, CHAP_C. The

By Laszlo Ersek · #76205 ·

[PUBLIC edk2 PATCH v2 07/10] NetworkPkg/IScsiDxe: reformat IScsiHexToBin() leading comment block

We'll need further return values for IScsiHexToBin() in a subsequent patch; make room for them in the leading comment block of the function. While at it, rewrap the comment block to 80 characters

By Laszlo Ersek · #76204 ·

[PUBLIC edk2 PATCH v2 04/10] NetworkPkg/IScsiDxe: clean up library class dependencies

Sort the library class dependencies in the #include directives and in the INF file. Remove the DpcLib class from the #include directives -- it is not listed in the INF file, and IScsiDxe doesn't call

By Laszlo Ersek · #76203 ·

[PUBLIC edk2 PATCH v2 05/10] NetworkPkg/IScsiDxe: fix potential integer overflow in IScsiBinToHex()

Considering IScsiBinToHex(): the following subexpressions are problematic: (*HexLength) - 3 BinLength * 2 BinLength * 2 + 3 The first one may wrap under zero, the latter two may wrap

By Laszlo Ersek · #76202 ·

[PUBLIC edk2 PATCH v2 03/10] NetworkPkg/IScsiDxe: clean up "ISCSI_CHAP_AUTH_DATA.OutChallengeLength"

The "ISCSI_CHAP_AUTH_DATA.OutChallenge" field is declared as a UINT8 array with ISCSI_CHAP_AUTH_MAX_LEN (1024) elements. However, when the challenge is generated and formatted, only ISCSI_CHAP_RSP_LEN

By Laszlo Ersek · #76201 ·

[PUBLIC edk2 PATCH v2 02/10] NetworkPkg/IScsiDxe: simplify "ISCSI_CHAP_AUTH_DATA.InChallenge" size

The ISCSI_CHAP_AUTH_MAX_LEN macro is defined with value 1024. The usage of this macro currently involves a semantic (not functional) bug, which we're going to fix in a subsequent patch,

By Laszlo Ersek · #76200 ·

[PUBLIC edk2 PATCH v2 01/10] NetworkPkg/IScsiDxe: wrap IScsiCHAP source files to 80 characters

Working with overlong lines is difficult for me; rewrap the CHAP-related source files in IScsiDxe to 80 characters width. No functional changes. Cc: Maciej Rabeda <maciej.rabeda@...> Cc:

By Laszlo Ersek · #76199 ·

[PUBLIC edk2 PATCH v2 00/10] NetworkPkg/IScsiDxe: fix IScsiHexToBin() security and functionality bugs

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3356 Repo: https://pagure.io/lersek/edk2.git Branch: iscsi_overflow_bz3356 The main goal of this series is to fix a remotely exploitable

By Laszlo Ersek · #76198 ·

Re: [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

Using FileHandleGetSize() saves some handling of a EFI_FILE_INFO pointer and freeing it etc (for getting the size of "cmdline" and "initrd"). But maybe it's better not to add another

By Dov Murik · #76197 ·

Re: [edk2-platforms][PATCH v2 19/32] AmpereAltraPkg: Add Random Number Generator Support

{ on preceding line. With that: Reviewed-by: Leif Lindholm <leif@...> / Leif

By Leif Lindholm <leif@...> · #76196 ·

Re: [PATCH V0 0/4] Enable Dynamic ACPI for LS1046AFRWY

Hi Vikas, Please resubmit this set, following the instructions set out by https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers as I

By Leif Lindholm <leif@...> · #76195 ·

Re: [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

Ard, do you have any comments please, on the topic at the bottom? My comments follow: The lib class header says "Provides interface to EFI_FILE_HANDLE functionality", which is not too bad; but I

By Laszlo Ersek · #76194 ·

Messages