|
|
Re: [PATCH v2 05/13] MdePkg/Register/Amd: define GHCB macro for the Page State Change
I verified that the values align with the GHCB spec publication:
#56421 Revision: 2.00
Reviewed-by: Erdem Aktas <erdemaktas@...>
|
I verified that the values align with the GHCB spec publication:
#56421 Revision: 2.00
Reviewed-by: Erdem Aktas <erdemaktas@...>
|
By
Erdem Aktas
·
#75227
·
|
|
Re: [PATCH v2 04/13] MdePkg/Register/Amd: define GHCB macro for Register GPA structure
I verified that the values align with the GHCB spec publication:
#56421 Revision: 2.00
Just one question: is there any reason why GHCB_* defines are decimal
while the SVM_EXIT_* are all in
|
I verified that the values align with the GHCB spec publication:
#56421 Revision: 2.00
Just one question: is there any reason why GHCB_* defines are decimal
while the SVM_EXIT_* are all in
|
By
Erdem Aktas
·
#75226
·
|
|
Re: [PATCH v2 03/13] MdePkg/Register/Amd: define GHCB macros for hypervisor feature detection
I verified that the values align with the GHCB spec publication:
#56421 Revision: 2.00
Reviewed-by: Erdem Aktas <erdemaktas@...>
-Erdem
|
I verified that the values align with the GHCB spec publication:
#56421 Revision: 2.00
Reviewed-by: Erdem Aktas <erdemaktas@...>
-Erdem
|
By
Erdem Aktas
·
#75225
·
|
|
Re: [PATCH v1 2/3] MdeModulePkg/PciBusDxe: Fix possible uninitialized use
If the function gets invalid value for the `ResizableBarOp` parameter
and asserts are disabled, `Bit` can be used uninitialized.
Cc: Jian J Wang <jian.j.wang@...>
Cc: Hao A Wu
|
If the function gets invalid value for the `ResizableBarOp` parameter
and asserts are disabled, `Bit` can be used uninitialized.
Cc: Jian J Wang <jian.j.wang@...>
Cc: Hao A Wu
|
By
Sergei Dmitrouk <sergei@...>
·
#75224
·
|
|
Re: [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add EHL microcode
Couple of comments:
1. Please fix the file description of MicrocodeUpdates.inf and make sure it reflects the contents of the file.
2. Since this is a new file, start with year 2021.
-Sai
|
Couple of comments:
1. Please fix the file description of MicrocodeUpdates.inf and make sure it reflects the contents of the file.
2. Since this is a new file, start with year 2021.
-Sai
|
By
Chaganty, Rangasai V
·
#75223
·
|
|
Re: [edk2-platforms][PATCH V2 10/11] Platform/Sgi: Add SMBIOS Type19 Table
Hi Pranav,
Please find my comments inline marked [SAMI].
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar
|
Hi Pranav,
Please find my comments inline marked [SAMI].
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar
|
By
Sami Mujawar
·
#75222
·
|
|
Re: [edk2-platforms][PATCH V2 06/11] Platform/Sgi: Add SMBIOS Type4 Table
Hi Pranav,
Please find my comments inline marked [SAMI].
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar
|
Hi Pranav,
Please find my comments inline marked [SAMI].
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar
|
By
Sami Mujawar
·
#75221
·
|
|
Re: [edk2-platforms][PATCH V2 11/11] Platform/Sgi: Add SMBIOS Type32 Table
Hi Pranav,
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
|
Hi Pranav,
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
|
By
Sami Mujawar
·
#75220
·
|
|
Re: [edk2-platforms][PATCH V2 09/11] Platform/Sgi: Add SMBIOS Type17 Table
Hi Pranav,
Please find my comments inline marked [SAMI].
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar
|
Hi Pranav,
Please find my comments inline marked [SAMI].
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar
|
By
Sami Mujawar
·
#75219
·
|
|
Re: [edk2-platforms][PATCH V2 08/11] Platform/Sgi: Add SMBIOS Type16 Table
Hi Pranav,
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
|
Hi Pranav,
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
|
By
Sami Mujawar
·
#75218
·
|
|
Re: [edk2-platforms][PATCH V2 07/11] Platform/Sgi: Add SMBIOS Type7 Table
Hi Pranav,
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
|
Hi Pranav,
Some comments in previous patches apply here as well and are not mentioned.
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
|
By
Sami Mujawar
·
#75217
·
|
|
Re: [edk2-platforms][PATCH V2 05/11] Platform/Sgi: Add SMBIOS Type3 Table
Hi Pranav,
Please find my comments inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI] typedef for enum?
|
Hi Pranav,
Please find my comments inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI] typedef for enum?
|
By
Sami Mujawar
·
#75216
·
|
|
Re: [edk2-platforms][PATCH V2 03/11] Platform/Sgi: Add Initial SMBIOS support
Hi Pranav,
Please find my comments inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
On 16/05/2021
|
Hi Pranav,
Please find my comments inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
On 16/05/2021
|
By
Sami Mujawar
·
#75215
·
|
|
Re: [edk2-platforms][PATCH V2 04/11] Platform/Sgi: Add SMBIOS Type1 Table
Hi Pranav,
Please find my comments inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI] CHAR8 ?
[SAMI] STATIC in capital
|
Hi Pranav,
Please find my comments inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI] CHAR8 ?
[SAMI] STATIC in capital
|
By
Sami Mujawar
·
#75214
·
|
|
Re: [edk2-platforms][PATCH V2 02/11] Platform/Sgi: Add GetProductId API for SGI/RD Platforms
Hi Pranav,
Please find my feedback inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI]
[SAMI] Please add doxygen header for
|
Hi Pranav,
Please find my feedback inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
[SAMI]
[SAMI] Please add doxygen header for
|
By
Sami Mujawar
·
#75213
·
|
|
Re: [edk2-platforms][PATCH V2 01/11] Platform/Sgi: Define RD-N2 platform id values
Hi Pranav,
Thank you for this patch.
This patch looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
|
Hi Pranav,
Thank you for this patch.
This patch looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@...>
Regards,
Sami Mujawar
|
By
Sami Mujawar
·
#75212
·
|
|
Re: [PATCH v2] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area
Yeah, I should have made mention of that in the commit message.
The restore is not performed for an SEV-ES guest (see FreeResetVector()),
because the memory is still needed.
This is the current
|
Yeah, I should have made mention of that in the commit message.
The restore is not performed for an SEV-ES guest (see FreeResetVector()),
because the memory is still needed.
This is the current
|
By
Lendacky, Thomas
·
#75211
·
|
|
Re: [edk2-platforms][PATCH v2 1/6] Platform/ARM/SgiPkg: sync with edk2 StandaloneMmCpu path change
Reviewed-by: Thomas Abraham <thomas.abraham@...>
|
Reviewed-by: Thomas Abraham <thomas.abraham@...>
|
By
Thomas Abraham
·
#75210
·
|
|
Re: [PATCH v2 06/13] MdePkg/Register/Amd: define GHCB macros for SNP AP creation
Yes, the APM is definitely lacking in this area.
The APs won't be in 64-bit mode when being started. In reset, they will be
in real mode, so the attributes will be set up for that. Please see
|
Yes, the APM is definitely lacking in this area.
The APs won't be in 64-bit mode when being started. In reset, they will be
in real mode, so the attributes will be set up for that. Please see
|
By
Lendacky, Thomas
·
#75209
·
|
|
Re: [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer
On Fri, May 14, 2021 at 12:49 PM Laszlo Ersek <lersek@...> wrote:
>
> For distributing ArmVirtPkg patch review tasks better, move Sami Mujawar
> from the "ArmVirtPkg: Kvmtool" section to the top-level
|
On Fri, May 14, 2021 at 12:49 PM Laszlo Ersek <lersek@...> wrote:
>
> For distributing ArmVirtPkg patch review tasks better, move Sami Mujawar
> from the "ArmVirtPkg: Kvmtool" section to the top-level
|
By
Leif Lindholm <leif@...>
·
#75208
·
|
