For GCC, it's using the reset vector in IntelFspWrapperPkg/FspWrapperSecCore/Vtf0/Bin/ResetVec.ia32.raw. Add the RAW file type to Rule.Common.SEC.BINARY in PlatformPkgGcc.fdf, so that GenFds can

Cc: David Wei <david.wei@...> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin <glin@...> --- Vlv2TbltDevicePkg/Library/PlatformFspLib/PlatformFspLib.c | 2

The original *.asm files are for Visual Studio. Copy the GAS assembly code from IntelFspWrapperPkg/Library/SecPeiFspPlatformSecLibSample/Ia32/ so that GCC can compile those code. Cc: David Wei

Also replacing LoadConstantToReg. Add that to commit message and: Reviewed-by: Leif Lindholm <leif.lindholm@...>

Fix the errors from GCC: Vlv2TbltDevicePkg/FspSupport/Library/PeiFspHobProcessLibVlv2/FspHobProcessLibVlv2.c: In function

This series of patches fixes the build errors when using GCC with "MINNOW2_FSP_BUILD = TRUE". I followed the release notes(*) and the coreboot wiki(**) to

Also replacing LoadConstantToReg. Add that to commit message and: Reviewed-by: Leif Lindholm <leif.lindholm@...>

CC:ing Andrew, who wrote it.

Yes, but due to the unfortunate naming of these macros conflicting with real functions existing in IoLib, this patch looks potentially horrifying at first glance. Hence I would prefer that to be

Commit version: SHA-1: 34a4babec8df5c1f5bf86f1cc83b3cc20016c62c Reviewed-By: Wu Jiaxin <jiaxin.wu@...>

Commit version: SHA-1: 210abffdca9015986a78d883647c85706fc39ee3 Reviewed-By: Wu Jiaxin <jiaxin.wu@...>

Hi Eric Do you have any comments for this patch. Best regards Lubo

Ok, I will update the log. Thanks Lubo

Reviewed-by: Eric Dong <eric.dong@...>

So how about adding your below sentences to the log message when you check in? I think it is more clear why we introduce the change to iSCSI. Others are good to me. Reviewed-by: Ye Ting

From my understanding, the default PcdAcpiExposedTableVersions is 0x3E, it can support ACPI table above version 1.0.but when changing the PCD to 0x3C, table 1.0 will not be installed and supported .

Eugene, I want to confirm with you the steps to reproduce the issue: 1. Set policy to DHCP. 2. If DHCP process is not complete yet, then run one App to invoke the UDP4 Configure with

Hi Lubo, Could you please describe the changes introduced by this patch in your log message? Thanks, Ting

Yes, it is in the code style document. You should update all patches for it. It looks like most of them will just be copy/paste. Oh, I see. I guess this patch updates the ResetPlatformSpecific

Thanks Ting's more background clarification. I assume the difference you mentioned is between "SHA-1: 3d0a49ad47619c30c84bbee8a33f54b64dddbcec" and "SHA-1: 7648748e99eeeadec38fda7568adb260c4acc861".