Reviewed-by: Nickle Wang <nickle.wang@...> Thanks, Nickle

Hi Jiewen, Ray, Could you help to review and give Review-by for this patch for fix CET shadow stack token busy bit issue ? As the common in v5 patch 1/2 by Limin, since it is a bug fix, it can still

Thanks for addressing my comment. The function header looks good to me now. Reviewed-by: Nickle Wang <nickle.wang@...> Thanks, Nickle

In Linux terms, there is a control dependency here. However, it should at least be a separate statement to load mCpuHotEjectData (which from my EDK2 reminiscences should be a global) into a local

Reviewed-by: Nickle Wang <nickle.wang@...> Thanks, Nickle

Reviewed-by: Nickle Wang <nickle.wang@...> Thanks, Nickle

Thanks for the link (and Paolo for writing it.) This is great. Yeah you are right. Just think out aloud here... without this it is possible that on the the AP, the CPU could reorder loads on line-1

I like this forumlation -- though I will get rid of the UINT64 -- I think as you pointed out above the mixture is a little awkward. Also acking comments above. Thanks. Yeah this is much

Hi Mars, I cannot extract the patch from your email. May be there are some problems with your git config. Do you have a fork repo in git? If yes, can you help to upload the change to your own

Could we decouple BSP and AP GDT in early waking up stage ? For example, AP uses temporary GDT (below 4GB) just for mode switching. Once AP is in the final stage, AP can reload GDT to match BSP.

Ray, BSP's GDT table is setup in CpuDxe and then MpInitLib re-uses BSP's GDT table for APs. 1, UefiCpuPkg\CpuDxe: gdt = AllocateRuntimePool (sizeof (GdtTemplate) + 8); ..... gdtPtr.Base =

“But we could allocate room under 4G for GDT table directly in CpuDxe.” The GDT pre-allocated is re-used by AP. Why do you suggest CpuDxe allocate GDT? Thanks, Ray From:

Update OemGetChassisType in OemMiscLib to return MISC_CHASSIS_TYPE instead of EFI_STATUS, which matches other OemMiscLib functions. Signed-off-by: Rebecca Cran <rebecca@...> ---

o Rename 'mHiiHandle' parameter in OemUpdateSmbiosInfo to 'HiiHandle'. o Rename 'Offset' parameter in OemUpdateSmbiosInfo to 'Field'. o Rename OemGetProcessorMaxSockets to OemGetMaxProcessors. o

The return type should be on the line before any EFIAPI specifier. Signed-off-by: Rebecca Cran <rebecca@...> --- ArmPkg/Include/Library/OemMiscLib.h | 14 +++++++-------

Update OemMiscLib with the following changes: o Fixed ordering of return type and EFIAPI specifier. o Renamed 'mHiiHandle' parameter in OemUpdateSmbiosInfo to 'HiiHandle'. o Renamed 'Offset'

Dear All: Got it. Thank you very much. Thanks 发件人: devel@edk2.groups.io <devel@edk2.groups.io>代表 fanjianfeng@... 发送时间: 2021年2月23日 9:18 收件人: devel@edk2.groups.io;

Update the external dependency (consumed by Edk2Tools) version for NASM, as agreed in recent community

Ray, Yes. You are right. Acutally, x64 IDT table cannot work correctly on protected mode. :-) But for GDT location, I agree it should be located under 4G space to support AP mode changing. But we

Jeff, You are right that BSP’s GDT and IDT tables are under 4G memory. It’s because when AP wakes up, it needs the GDT for entering protected mode. AP cannot access above 4G memory without