From: Tom Lendacky <thomas.lendacky@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3008 The VmgExitLib library added two new interfaces, VmgSetOffsetValid() and VmgIsOffsetValid(), that

From: Tom Lendacky <thomas.lendacky@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3008 In upcoming patches, the setting of the bits in the GHCB ValidBitmap will be performed in

From: Tom Lendacky <thomas.lendacky@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3008 Use OFFSET_OF () and sizeof () to calculate the GHCB register field offsets instead of hardcoding

From: Tom Lendacky <thomas.lendacky@...> This patch series provides some fixes, updates and cleanup to the SEV-ES guest support: - Update the calculation of the qword offset of fields within the

This change doesn't follow SmBios spec. It is not required. So, this patch and another change in EmulatorPkg can be removed. Thanks Liming

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2952 Add PROCESSOR_CHARACTERISTIC_FLAGS struct information in SMBIOS_TABLE_TYPE4 mCpuSmbiosType4 parameter Cc: Jordan Justen

Reviewed-by: Nickle Wang <nickle.wang@...>

Hi Abner, I have comment for function RestJsonStructureUnload(). Please check my inline comment below. Thanks, Nickle

Hi Abner, I found an issue on function header of EFI_REST_JSON_STRUCTURE_REGISTER that is not follow UEFI spec. Thanks, Nickle

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2952 In PROCESSOR_ID_DATA struct add a PROCESSOR_CHARACTERISTIC_FLAGS character Cc: Michael D Kinney <michael.d.kinney@...> Cc: Liming Gao

Reviewed-by: Nickle Wang <nickle.wang@...>

Hi Abner, Do we need to specify the library instance under [Components] section when they are specified in [LibraryClasses] already? Thanks, Nickle

Reviewed-by: Nickle Wang <nickle.wang@...>

Hi Abner, I do not see any usage of DEBUG macro in this NULL library so maybe "DebugLib" could be removed from INF file. Thanks, Nickle

Hi Abner, I found that the parameter is not defined as it is described in function header. Please check my comment inline below. Thanks, Nickle

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2952 In MdePkg/SmBios.h,there are two additional DWORD added for type 17,but these two DWORD do not show in SmbiosView, So add them. Cc: Ray Ni

Reviewed-by: Nickle Wang <nickle.wang@...>

Thank you for the test confirmation. Regards, Michael

Looks good to me. Reviewed-by: Zailiang Sun <zailiang.sun@...>