Reviewed-by: Liming Gao <gaoliming@...>

Reviewed-by: Liming Gao <gaoliming@...> Merge @ b0459fb6cf5083f5fcdf91d1e1518a86b22add1b in edk2-platform. Thanks Liming

Reviewed-by: Liming Gao <gaoliming@...> directory

This patch looks good. Reviewed-by: Bob Feng <bob.c.feng@...>

Remove some defined variable but not used. Linux build option[-Werror=unused-but-set-variable] treat all warnings as errors. Cc: Bob Feng <bob.c.feng@...> Cc: Liming Gao

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...> On 10/12/20, 7:44 PM, "fengyunhua" <fengyunhua@...> wrote: Error message: raise Exception ("'%s' is not a valid

Hi, I’m a new intern and I was trying to add a library in the DCG10nm project which lead to a fatal error while building. Please can you help me out for finding and resolving the issue. PFA of

Hi, Liming: From Build.log, it seems include path is ok: ...... cl.exe" /Foy:\Build\ZxxPlatformPkg\DEBUG_VS2015x86\X64\CryptoPkg\Library\BaseCryptLib\RuntimeCryptLib\OUTPUT\Hash\ /showIncludes /nologo

The patch looks good to me. Before take my R-B, have you tested the patch. It is better to get another Tested-by. By the way, it is highly recommended to add one BZ to descript the change and keep a

Reminder: TianoCore Bug Triage - APAC / NAMO When: Tuesday, 13 October 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los

Got it. Here should be _MAX_PATH. Yunhua, can you fix this build issue on Linux? Thanks Liming

Reviewed-by: Maurice Ma <maurice.ma@...>

Reviewed-by: Maurice Ma <maurice.ma@...>

I’ll try to take a look at that today. Thanks! - Bret

Hi Bret, The concept of making the platform lock point configurable seems like a good idea from a platform porting perspective. If we had that feature would that make this better? Have you

The problem with the other solution is that it doesn’t give the platform any flexibility to move which event the lock is attached to. For EDK2 default, we’re making it EndOfDxe, because that

SBSA generic watchdog timer structure entry has been added to GTDT table as per BSAv0.9. This enables acpi detection of wdt in qemu sbsa platform Signed-off-by: Shashi Mallela

To enable detection of qemu SBSA generic watchdog timer device,this patch has been added to create sbsa-wdt entry into the GTDT table which helps firmware report the presence of SBSA-wdt to the

Hi Bret, If the other solution more directly expresses the dependency and guarantees ordering, then it may not be considered a hack. I prefer solutions that minimize the chances of failures

* Add needed PcdPciExpressBaseSize default on Ia32 targets analog to X64 in: 8028b2907e20b21cd7d69639a36ac82a77c81dc1 * Remove no longer required build-time PcdPciExpressBaseAddress with regard= s