|
Re: [PATCH] Add a stub CONTRIBUTING.md pointing to the wiki
Merged as commit 7e6f150b6902, via
<https://github.com/tianocore/edk2/pull/890>.
Thanks
Laszlo
Merged as commit 7e6f150b6902, via
<https://github.com/tianocore/edk2/pull/890>.
Thanks
Laszlo
|
By
Laszlo Ersek
·
#64397
·
|
|
Re: [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
Whoops, I failed to file this away in my queue - apologies.
Many thanks for fixing this in opensbi.
Reviewed-by: Leif Lindholm <leif@...>
Whoops, I failed to file this away in my queue - apologies.
Many thanks for fixing this in opensbi.
Reviewed-by: Leif Lindholm <leif@...>
|
By
Leif Lindholm <leif@...>
·
#64396
·
|
|
Re: [Wiki][Patch V2] Add EDK II Code First Process Wiki Page
Minor typo below:
Drop "a"?
Reviewed-by: Leif Lindholm <leif@...>
Minor typo below:
Drop "a"?
Reviewed-by: Leif Lindholm <leif@...>
|
By
Leif Lindholm <leif@...>
·
#64395
·
|
|
Re: [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset
Jiewen,
I don’t completely agree with your second point. If the underlying issue is already out of embargo, and we’ve just failed to fix it, that’s not a new issue. I would want to see fixes
Jiewen,
I don’t completely agree with your second point. If the underlying issue is already out of embargo, and we’ve just failed to fix it, that’s not a new issue. I would want to see fixes
|
By
Bret Barkelew <bret.barkelew@...>
·
#64394
·
|
|
Re: [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
Hi Vladimir,
I am inprog of going through the patch. There are some coding standard violations.
For reference: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/
Http.c:
Lines
Hi Vladimir,
I am inprog of going through the patch. There are some coding standard violations.
For reference: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/
Http.c:
Lines
|
By
Maciej Rabeda
·
#64393
·
|
|
Re: [Patch] SecurityPkg/OpalPassword: Fix spelling mistake
Reviewed-by: Jian J Wang <jian.j.wang@...>
Regards,
Jian
Reviewed-by: Jian J Wang <jian.j.wang@...>
Regards,
Jian
|
By
Wang, Jian J
·
#64392
·
|
|
Re: [Patch 5/6] SecurityPkg: Fix spelling mistake for occurred
Reviewed-by: Jian J Wang <jian.j.wang@...>
Regards,
Jian
Reviewed-by: Jian J Wang <jian.j.wang@...>
Regards,
Jian
|
By
Wang, Jian J
·
#64391
·
|
|
Re: [PATCH v2 2/2] CryptoPkg/OpensslLib: Commit the auto-generated assembly files for X64
Jian,
I want the BaseTools maintainers to evaluate these build requirements.
We already have a number of tool dependencies. Adding one more for perl
may be acceptable.
Mike
Jian,
I want the BaseTools maintainers to evaluate these build requirements.
We already have a number of tool dependencies. Adding one more for perl
may be acceptable.
Mike
|
By
Michael D Kinney
·
#64390
·
|
|
Re: [PATCH v2 2/2] CryptoPkg/OpensslLib: Commit the auto-generated assembly files for X64
Christopher,
Can you provide the details on how to generate the IA32 and X64 files? What is the additional parameter?
Thanks,
Mike
Christopher,
Can you provide the details on how to generate the IA32 and X64 files? What is the additional parameter?
Thanks,
Mike
|
By
Michael D Kinney
·
#64389
·
|
|
Re: [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset
I dug up the original report details. This was noted as a concern during a source code inspection. There was no demonstration of how it might be triggered.
" There is an integer overflow
I dug up the original report details. This was noted as a concern during a source code inspection. There was no demonstration of how it might be triggered.
" There is an integer overflow
|
By
Mathews, John
·
#64388
·
|
|
Re: [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008
I agree with the process and withdraw my request, replacing it instead with a disapproving head shake and deep sigh. I’ll go back to pushing on this after the tag.
- Bret
I agree with the process and withdraw my request, replacing it instead with a disapproving head shake and deep sigh. I’ll go back to pushing on this after the tag.
- Bret
|
By
Bret Barkelew <bret.barkelew@...>
·
#64387
·
|
|
[PATCH edk2-platforms v1 1/1] Platform/ARM/SgiPkg: Replace BSD License with BSD+Patent License
https://bugzilla.tianocore.org/show_bug.cgi?id=2902
Replace BSD 2-Clause License with BSD+Patent License. This change is
based on https://bugzilla.tianocore.org/show_bug.cgi?id=1373 and
https://bugzilla.tianocore.org/show_bug.cgi?id=2902
Replace BSD 2-Clause License with BSD+Patent License. This change is
based on https://bugzilla.tianocore.org/show_bug.cgi?id=1373 and
|
By
Sami Mujawar
·
#64386
·
|
|
Re: [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset
Hi Laszlo
I agree with on your most points.
It is all about *return of investment* or *risk control*. Like we cannot pursue 100% security because we will bankrupt ourselves if so.
Here I just raise
Hi Laszlo
I agree with on your most points.
It is all about *return of investment* or *risk control*. Like we cannot pursue 100% security because we will bankrupt ourselves if so.
Here I just raise
|
By
Yao, Jiewen
·
#64385
·
|
|
Re: [PATCH v4 8/8] IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib
Reviewed-by: Chasel Chiu <chasel.chiu@...>
Reviewed-by: Chasel Chiu <chasel.chiu@...>
|
By
Chiu, Chasel
·
#64384
·
|
|
[PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
From: Tom Lendacky <thomas.lendacky@...>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2901
The DoDecrement variable in ApWakeupFunction () wasn't always being
initialized. Update the code
From: Tom Lendacky <thomas.lendacky@...>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2901
The DoDecrement variable in ApWakeupFunction () wasn't always being
initialized. Update the code
|
By
Lendacky, Thomas
·
#64383
·
|
|
Re: [PATCH v4 6/8] IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and PcdFspMeasurementConfig.
Copyright year of IntelFsp2WrapperPkg.dec can be extend to 2020 when pushing.
Reviewed-by: Chasel Chiu <chasel.chiu@...>
Copyright year of IntelFsp2WrapperPkg.dec can be extend to 2020 when pushing.
Reviewed-by: Chasel Chiu <chasel.chiu@...>
|
By
Chiu, Chasel
·
#64382
·
|
|
Re: [PATCH v4 4/8] IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement.
Reviewed-by: Chasel Chiu <chasel.chiu@...>
Reviewed-by: Chasel Chiu <chasel.chiu@...>
|
By
Chiu, Chasel
·
#64381
·
|
|
Re: [PATCH v4 3/8] IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.
Reviewed-by: Chasel Chiu <chasel.chiu@...>
Reviewed-by: Chasel Chiu <chasel.chiu@...>
|
By
Chiu, Chasel
·
#64380
·
|
|
Re: [PATCH v4 2/8] IntelFsp2WrapperPkg/FspMeasurementLib: Add header file.
Reviewed-by: Chasel Chiu <chasel.chiu@...>
Reviewed-by: Chasel Chiu <chasel.chiu@...>
|
By
Chiu, Chasel
·
#64379
·
|
|
Re: [PATCH v15 00/46] SEV-ES guest support
Hi Liming,
Yes, fix is on the way.
Thanks,
Tom
Hi Liming,
Yes, fix is on the way.
Thanks,
Tom
|
By
Lendacky, Thomas
·
#64378
·
|