I am fine with that. BTW, it is better to add a BZ for this change. BZ would make a good history of the discussion on this feature or bug fix. Consumers may not aware of the discussion thru

From: Michael Kubacki <michael.kubacki@...> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2887 The local Private pointer variable in SetTheImage() is initialized based on the caller

When submitting a new pull request via the web UI, github will link to CONTRIBUTING.md for that repo if it exists. I just tried with virt-manager: for first time PRs it will give a pop up

Does github display "CONTRIBUTING.md" automatically? Hm... If I check <https://github.com/virt-manager/virt-manager/>, there's an explicit reference to "CONTRIBUTING.md" at the bottom of "README.md";

I'd like to know as well. Thanks Laszlo

Upstreamed by Commit ID: cf364d100690e635897f48ade769583d19a78ed0

Reviewed-by: G Edhaya Chandran<edhaya.chandran@...>

I realized there is room for misinterpretation of the macros LAST_ATTEMPT_STATUS_DRIVER_ERROR_COUNT and LAST_ATTEMPT_STATUS_DEPENDENCY_ERROR_COUNT based on name. If there's no further feedback on the

Reviewed-by: G Edhaya Chandran<edhaya.chandran@...> Upstreamed by Commit: 57280728e277c66d7803592cf071d87a21654d09

Reviewed-by: G Edhaya Chandran<edhaya.chandran@...> Upstreamed by Commit: fd5996f2d060a090c0d4bb0107a8790221539eb9

Upstreamed by Commit: 5588ebe78620e7ee99bc56a08e964499af52a63b

Upstreamed by Commits ID 57280728e277c66d7803592cf071d87a21654d09 fd5996f2d060a090c0d4bb0107a8790221539eb9 5588ebe78620e7ee99bc56a08e964499af52a63b

Reviewed-by: G Edhaya Chandran<edhaya.chandran@...>

Googling for 'edk2 pull request' did not find this wiki page: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Add it to CONTRIBUTING.md for more

#1: In v3, I'm going to split it such that the defines are in the public header and the enum specifying the internal driver and dependency ranges are in a private header to FmpDevicePkg. Here's the

These patches fix two issues running the BaseTools test suite on python 3.9 from Fedora rawhide. See patches for individual details Cole Robinson (2): BaseTools: fix ucs-2 lookup on python 3.9

python3.9 changed/fixed codec.register behavior to always replace hyphen with underscore for passed in codec names: https://bugs.python.org/issue37751 So the custom Ucs2Search needs to be adapted

In python3, array.array.tostring() was a compat alias for tobytes(). tostring() was removed in python 3.9. Convert this to use tolist() which should be valid for all python versions. This fixes this

Hi Qi, Two common comments here. More specific comments will be given separately in each patch email later. c1. SecurityPkg/Library/DxeTpmMeasurementLib/EventLogRecord.c and

No worries, easy enough to do if I'm already updating the others. I would like to be able to run this tool on my system, though, to see if anything else gets flagged after fixing the above mentioned